Summary: | 'strings --help' talks about zero-terminated strings | ||
---|---|---|---|
Product: | binutils | Reporter: | Georg Brandl <g.brandl> |
Component: | binutils | Assignee: | Not yet assigned to anyone <unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | nickc |
Priority: | P2 | ||
Version: | 2.37 | ||
Target Milestone: | --- | ||
Host: | Target: | ||
Build: | Last reconfirmed: |
Description
Georg Brandl
2021-11-28 17:40:29 UTC
The master branch has been updated by Nick Clifton <nickc@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8fee99c3c8e25f2708bddde345c192dd2f3e7e08 commit 8fee99c3c8e25f2708bddde345c192dd2f3e7e08 Author: Nick Clifton <nickc@redhat.com> Date: Mon Nov 29 14:52:42 2021 +0000 Update description of string's -n option. PR 28632 * strings.c (usage): Update desciption of -n option. * doc/binutils.texi: Likewise. Hi Georg, Thanks for raising this issue. I have checked in a patch which changes the --help output to read: -n <number> Locate & print any sequence of at least <number> --bytes=<number> displayable characters. (The default is 4). And I have updated the description in binutils.texi so that it goes into a bit more detail: Print sequences of displayable characters that are at least <min-len> characters long. If not specified a default minimum length of 4 is used. The distinction between displayable and non-displayable characters depends upon the setting of the -e and -U options. Sequences are always terminated at control characters such as new-line and carriage-return, but not the tab character. Cheers Nick Great, thanks! While checking it out (-U was new to me), I noticed that in the --help string and the comment at the top of strings.c it is referred to as (lowercase) -u - maybe you can fix this as well. The master branch has been updated by Nick Clifton <nickc@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=584294c4066d0101161e4e04744a46cce7a7863e commit 584294c4066d0101161e4e04744a46cce7a7863e Author: Nick Clifton <nickc@redhat.com> Date: Mon Nov 29 15:37:24 2021 +0000 strings: Replace references to -u option with references to -U. PR 28632 (In reply to Georg Brandl from comment #3) > Great, thanks! While checking it out (-U was new to me), It is a brand new option... :-) > I noticed that in > the --help string and the comment at the top of strings.c it is referred to > as (lowercase) -u - maybe you can fix this as well. Done. |