Summary: | assert in abg-reader.cc:1389 when doing a self test on libjavascriptcoregtk-4.0.so.18.18.7 | ||
---|---|---|---|
Product: | libabigail | Reporter: | Ben Woodard <woodard> |
Component: | default | Assignee: | Dodji Seketeli <dodji> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | libabigail |
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Host: | Target: | ||
Build: | Last reconfirmed: | ||
Bug Depends on: | |||
Bug Blocks: | 27019 |
Description
Ben Woodard
2021-09-21 20:30:42 UTC
This one appears fixed in master now. I am not sure exactly what patch fixes it, but I can't reproduce it anymore with this one: c00add2a Bug 27086 - Consider all C++ virtual destructors when there are many. I am testing using Rawhide, and the package I used is this one: webkit2gtk3-jsc-2.33.3-3.fc36.x86_64 Thanks for reporting this. I just pulled git and retested this one with head as c00add2a211d7d6a380ce5a248accca978975933 and the problem still reproduces for me: $ abidw --abidiff /usr/lib64/libjavascriptcoregtk-4.0.so.18.18.7 abidw: ../../../libabigail/src/abg-reader.cc:1389: abigail::ir::type_base_sptr abigail::xml_reader::read_context::build_or_get_type_decl(const string&, bool): Assertion `__abg_cond__' failed. Aborted (core dumped) Could you retest your latest with webkit2gtk3-jsc-2.32.3-1.fc34.x86_64 rather than the one from rawhide. Maybe there is something subtle about that version that crashing on my system that is fixed in rawhide. Just reconfirmed that this continues to happen as of trunk faba5ababb6622a9f0a6c482645bbd78c2541a2f The line number changed slightly though. It is now line 1400. Starting program: /home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw --abidiff /usr/lib64/libjavascriptcoregtk-4.0.so.18.18.8 [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". abidw: ../../../libabigail/src/abg-reader.cc:1400: abigail::ir::type_base_sptr abigail::xml_reader::read_context::build_or_get_type_decl(const string&, bool): Assertion `__abg_cond__' failed. Program received signal SIGABRT, Aborted. __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49 49 return ret; #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49 #1 0x00007ffff75148a4 in __GI_abort () at abort.c:79 #2 0x00007ffff7514789 in __assert_fail_base (fmt=<optimized out>, assertion=<optimized out>, file=<optimized out>, line=<optimized out>, function=<optimized out>) at assert.c:92 #3 0x00007ffff7523a16 in __GI___assert_fail (assertion=0x7ffff7f34f15 "__abg_cond__", file=0x7ffff7f476b0 "../../../libabigail/src/abg-reader.cc", line=1400, function=0x7ffff7f479f8 "abigail::ir::type_base_sptr abigail::xml_reader::read_context::build_or_get_type_decl(const string&, bool)") at assert.c:101 #4 0x00007ffff7e9cb05 in abigail::xml_reader::read_context::build_or_get_type_decl (this=0x8c836ca0, id=..., add_decl_to_scope=<optimized out>) at ../../../libabigail/src/abg-reader.cc:1400 #5 0x00007ffff7ea7342 in abigail::xml_reader::build_typedef_decl (ctxt=..., node=0xe45ca940, add_to_current_scope=<optimized out>) at ../../../libabigail/src/abg-reader.cc:4542 <snip> #8368 0x00007ffff7ea3873 in abigail::xml_reader::read_corpus_from_input (ctxt=...) at ../../../libabigail/src/abg-reader.cc:2035 #8369 0x00000000004057b1 in load_corpus_and_write_abixml (opts=..., context=std::shared_ptr<abigail::dwarf_reader::read_context> (empty) = {...}, env=std::shared_ptr<abigail::ir::environment> (use count 1, weak count 0) = {...}, argv=0x7fffffffd818) at /usr/include/c++/11/bits/shared_ptr_base.h:979 #8370 main (argc=<optimized out>, argv=0x7fffffffd818) at ../../../libabigail/tools/abidw.cc:915 [ben@alien libabigail]$ This should hopefully now be fixed by https://sourceware.org/git/?p=libabigail.git;a=commit;h=7f57aa7959ef4a715822b0d3fb2647bbad90afc8. Should be available in libabigail 2.1. Thanks! |