Bug 26435

Summary: UBSAN error: bfd/elf32-cr16.c:928:21:
Product: binutils Reporter: Martin Liska <mliska>
Component: binutilsAssignee: Alan Modra <amodra>
Status: RESOLVED FIXED    
Severity: normal    
Priority: P2    
Version: 2.34   
Target Milestone: 2.36   
Host: Target:
Build: Last reconfirmed: 2020-08-30 00:00:00

Description Martin Liska 2020-08-20 12:17:11 UTC
The following fails when I build binutils with:
configure --build=x86_64-linux --disable-nls --disable-gdb --disable-gdbserver --disable-sim --disable-readline --disable-libdecnumber --enable-obsolete --target=cr16-elf CFLAGS="-g -O2 -fsanitize=address,undefined -Wno-error" CXXLAGS="-g -O2 -fsanitize=address,undefined -Wno-error" LDFLAGS="-ldl"
Target: cr16-elf
PASS: changelma (pr20659)
Executing on host: sh -c {./ld-new   -L/home/mliska/Programming/binutils/ld/testsuite/ld-elf   -o tmpdir/dump tmpdir/comm-data4.o  2>&1}  /dev/null dump.tmp (timeout = 300)
/home/mliska/Programming/binutils/bfd/elf32-cr16.c:928:21: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
Comment 1 Sourceware Commits 2020-08-30 13:21:54 UTC
The master branch has been updated by Alan Modra <amodra@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=34d8e6d0c5f3c51d0e7858572791d8269b9d0f1c

commit 34d8e6d0c5f3c51d0e7858572791d8269b9d0f1c
Author: Alan Modra <amodra@gmail.com>
Date:   Sun Aug 30 19:37:15 2020 +0930

    PR26435, PR26436 UBSAN: elf32-cr16.c:928 left shift
    
            PR 26435
            PR 26436
            * elf32-cr16.c (cr16_elf_final_link_relocate): Calculate reloc_bits
            without undefined behaviour.
Comment 2 Alan Modra 2020-08-30 13:26:03 UTC
Fixed