Summary: | disable support for glibc mcheck | ||
---|---|---|---|
Product: | gdb | Reporter: | Frank Ch. Eigler <fche> |
Component: | build | Assignee: | Not yet assigned to anyone <unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | tromey |
Priority: | P2 | ||
Version: | unknown | ||
Target Milestone: | --- | ||
See Also: | https://sourceware.org/bugzilla/show_bug.cgi?id=9939 | ||
Host: | Target: | ||
Build: | Last reconfirmed: |
Description
Frank Ch. Eigler
2019-08-06 15:29:24 UTC
It seems like a good idea to me. Send the patch to gdb-patches, details in the contribution checklist: https://sourceware.org/gdb/wiki/ContributionChecklist Pushed, thanks for the quick review! The master branch has been updated by Frank Ch. Eigler <fche@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=404f29021abaef86a341663444fb069eb1f0282a commit 404f29021abaef86a341663444fb069eb1f0282a Author: Frank Ch. Eigler <fche@redhat.com> Date: Tue Aug 6 11:23:48 2019 -0400 [PR build/24886] disable glibc mcheck support This patch drops gdb's configury support for glibc's mcheck function. It has been observed to cause false abort()s, because it is thread-unsafe yet interposes every malloc/free operation. So if any library transitively used by gdb also uses threads, then these functions can easily corrupt their own checking data. These days, gcc ASAN and valgrind provide high quality checking, and mcheck is apparently itself being slowly deprecated. So, let's stop linking to it. Attached patch drops the autoconf/Makefile machinery for both gdb and gdbserver. No testsuite-visible impact. IMHO not worth mentioning in NEWS. See also: https://sourceware.org/bugzilla/show_bug.cgi?id=9939 gdb/ChangeLog PR build/24886 * configure.ac: Drop enable-libmcheck support. * configure, config.in: Rebuild. * libmcheck.m4: Remove. * acinclude.m4: Don't include it. * Makefile.in: Don't distribute it. * top.c (print_gdb_configuration): Don't mention it. gdb/gdbserver/ChangeLog PR build/24886 * configure.ac: Drop enable-libmcheck support. * configure, config.in: Rebuild. * acinclude.m4: Don't include it. |