Summary: | Malloc tunables give tcache assertion failures | ||
---|---|---|---|
Product: | glibc | Reporter: | Wilco <wdijkstr> |
Component: | malloc | Assignee: | Not yet assigned to anyone <unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fweimer, howaboutsynergy |
Priority: | P2 | Flags: | fweimer:
security-
|
Version: | 2.26 | ||
Target Milestone: | 2.30 | ||
Host: | Target: | ||
Build: | Last reconfirmed: |
Description
Wilco
2019-05-07 13:36:14 UTC
The master branch has been updated by Wilco Dijkstra <wilco@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5ad533e8e65092be962e414e0417112c65d154fb commit 5ad533e8e65092be962e414e0417112c65d154fb Author: Wilco Dijkstra <wdijkstr@arm.com> Date: Fri May 10 16:38:21 2019 +0100 Fix tcache count maximum (BZ #24531) The tcache counts[] array is a char, which has a very small range and thus may overflow. When setting tcache_count tunable, there is no overflow check. However the tunable must not be larger than the maximum value of the tcache counts[] array, otherwise it can overflow when filling the tcache. [BZ #24531] * malloc/malloc.c (MAX_TCACHE_COUNT): New define. (do_set_tcache_count): Only update if count is small enough. * manual/tunables.texi (glibc.malloc.tcache_count): Document max value. Fixed for GLIBC 2.30. The release/2.29/master branch has been updated by Wilco Dijkstra <wilco@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=95d66fecaabbc92ab53027e808f0fc1929c9f21a commit 95d66fecaabbc92ab53027e808f0fc1929c9f21a Author: Wilco Dijkstra <wdijkstr@arm.com> Date: Fri May 10 16:38:21 2019 +0100 Fix tcache count maximum (BZ #24531) The tcache counts[] array is a char, which has a very small range and thus may overflow. When setting tcache_count tunable, there is no overflow check. However the tunable must not be larger than the maximum value of the tcache counts[] array, otherwise it can overflow when filling the tcache. [BZ #24531] * malloc/malloc.c (MAX_TCACHE_COUNT): New define. (do_set_tcache_count): Only update if count is small enough. * manual/tunables.texi (glibc.malloc.tcache_count): Document max value. (cherry picked from commit 5ad533e8e65092be962e414e0417112c65d154fb) The release/2.28/master branch has been updated by Wilco Dijkstra <wilco@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=58d2672f64176fcb323859d3bd5240fb1cf8f25c commit 58d2672f64176fcb323859d3bd5240fb1cf8f25c Author: Wilco Dijkstra <wdijkstr@arm.com> Date: Fri May 10 16:38:21 2019 +0100 Fix tcache count maximum (BZ #24531) The tcache counts[] array is a char, which has a very small range and thus may overflow. When setting tcache_count tunable, there is no overflow check. However the tunable must not be larger than the maximum value of the tcache counts[] array, otherwise it can overflow when filling the tcache. [BZ #24531] * malloc/malloc.c (MAX_TCACHE_COUNT): New define. (do_set_tcache_count): Only update if count is small enough. * manual/tunables.texi (glibc.malloc.tcache_count): Document max value. (cherry picked from commit 5ad533e8e65092be962e414e0417112c65d154fb) The release/2.27/master branch has been updated by Wilco Dijkstra <wilco@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=54ba8bcd42355ad0c0ca763b6bba40a2b2829f38 commit 54ba8bcd42355ad0c0ca763b6bba40a2b2829f38 Author: Wilco Dijkstra <wdijkstr@arm.com> Date: Fri May 10 16:38:21 2019 +0100 Fix tcache count maximum (BZ #24531) The tcache counts[] array is a char, which has a very small range and thus may overflow. When setting tcache_count tunable, there is no overflow check. However the tunable must not be larger than the maximum value of the tcache counts[] array, otherwise it can overflow when filling the tcache. [BZ #24531] * malloc/malloc.c (MAX_TCACHE_COUNT): New define. (do_set_tcache_count): Only update if count is small enough. * manual/tunables.texi (glibc.malloc.tcache_count): Document max value. (cherry picked from commit 5ad533e8e65092be962e414e0417112c65d154fb) The release/2.26/master branch has been updated by Wilco Dijkstra <wilco@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ac92c66821fae2ae6587114acc454f97a6bc7859 commit ac92c66821fae2ae6587114acc454f97a6bc7859 Author: Wilco Dijkstra <wdijkstr@arm.com> Date: Fri May 10 16:38:21 2019 +0100 Fix tcache count maximum (BZ #24531) The tcache counts[] array is a char, which has a very small range and thus may overflow. When setting tcache_count tunable, there is no overflow check. However the tunable must not be larger than the maximum value of the tcache counts[] array, otherwise it can overflow when filling the tcache. [BZ #24531] * malloc/malloc.c (MAX_TCACHE_COUNT): New define. (do_set_tcache_count): Only update if count is small enough. * manual/tunables.texi (glibc.malloc.tcache_count): Document max value. (cherry picked from commit 5ad533e8e65092be962e414e0417112c65d154fb) |