| Summary: | gdb.execute("show commands") doesn't work | ||
|---|---|---|---|
| Product: | gdb | Reporter: | Simon Marchi <simark> |
| Component: | python | Assignee: | Not yet assigned to anyone <unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ampva300, gutterinstallationarvada, harbercandelario6kzj, hawex77340, ivankamalikova50, jackmarrow35, kenhobbs1227, morningstarlucifer0502, movem.wlc, service.momoscheckout, tomwalterszz0809 |
| Priority: | P2 | ||
| Version: | HEAD | ||
| Target Milestone: | 8.2.1 | ||
| Host: | Target: | ||
| Build: | Last reconfirmed: | ||
This started to fail at
56bcdbea2bed ("Let gdb.execute handle multi-line commands")
which means it started to fail in gdb 8.2. A fix for this could make its way in gdb 8.2.1. I have a tentative fix, which is to get rid of command_name_equals.
The master branch has been updated by Simon Marchi <simark@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8588b356927dabd582d1d67f87a161027cb2aed1 commit 8588b356927dabd582d1d67f87a161027cb2aed1 Author: Simon Marchi <simon.marchi@polymtl.ca> Date: Mon Sep 17 08:26:24 2018 -0400 python: Make gdb.execute("show commands") work (PR 23669) Since commit 56bcdbea2bed ("Let gdb.execute handle multi-line commands") trying to use a command like gdb.execute("show commands") in Python fails. GDB ends up trying to run the "commands" command. The reason is that GDB gets confused with the special "commands" command. In process_next_line, the lookup_cmd_1 function returns the cmd_list_element representing the "commands" sub-command of "show". Lower, we check the cmd_list_element to see if it matches various control commands by name, including the "commands" command. This is where we wrongfully conclude that the executed command must be "commands", when in reality it was "show commands". The fix proposed in this patch removes the comparisons by name, instead comparing the cmd_list_element object by pointer with the objects created at initialization time. Tested on the buildbot, though on a single builder (Fedora-x86_64-m64). gdb/ChangeLog: PR python/23669 * breakpoint.c (commands_cmd_element): New. (_initialize_breakpoint): Assign commands_cmd_element. * breakpoint.h (commands_cmd_element): New. * cli/cli-script.c (while_cmd_element, if_command, define_cmd_element): New. (command_name_equals): Remove. (process_next_line): Compare commands by pointer, not by name. (_initialize_cli_script): Assign the various cmd_list_element variables. * compile/compile.c (compile_cmd_element): New. (_initialize_compile): Assign compile_cmd_element. * compile/compile.h (compile_cmd_element): New. * guile/guile.c (guile_cmd_element): New. (install_gdb_commands): Assign guile_cmd_element. * guile/guile.h (guile_cmd_element): New. * python/python.c (python_cmd_element): New. (_initialize_python): Assign python_cmd_element. * python/python.h (python_cmd_element): New. * tracepoint.c (while_stepping_cmd_element): New. (_initialize_tracepoint): Assign while_stepping_cmd_element. * tracepoint.h (while_stepping_cmd_element): New. gdb/testsuite/ChangeLog: PR python/23669 * gdb.python/python.exp: Test gdb.execute("show commands"). The gdb-8.2-branch branch has been updated by Simon Marchi <simark@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b13ab533d38674e6273eb78eeef261d5b0655bbf commit b13ab533d38674e6273eb78eeef261d5b0655bbf Author: Simon Marchi <simon.marchi@polymtl.ca> Date: Mon Sep 17 08:26:24 2018 -0400 python: Make gdb.execute("show commands") work (PR 23669) Since commit 56bcdbea2bed ("Let gdb.execute handle multi-line commands") trying to use a command like gdb.execute("show commands") in Python fails. GDB ends up trying to run the "commands" command. The reason is that GDB gets confused with the special "commands" command. In process_next_line, the lookup_cmd_1 function returns the cmd_list_element representing the "commands" sub-command of "show". Lower, we check the cmd_list_element to see if it matches various control commands by name, including the "commands" command. This is where we wrongfully conclude that the executed command must be "commands", when in reality it was "show commands". The fix proposed in this patch removes the comparisons by name, instead comparing the cmd_list_element object by pointer with the objects created at initialization time. Tested on the buildbot, though on a single builder (Fedora-x86_64-m64). gdb/ChangeLog: PR python/23669 * breakpoint.c (commands_cmd_element): New. (_initialize_breakpoint): Assign commands_cmd_element. * breakpoint.h (commands_cmd_element): New. * cli/cli-script.c (while_cmd_element, if_command, define_cmd_element): New. (command_name_equals): Remove. (process_next_line): Compare commands by pointer, not by name. (_initialize_cli_script): Assign the various cmd_list_element variables. * compile/compile.c (compile_cmd_element): New. (_initialize_compile): Assign compile_cmd_element. * compile/compile.h (compile_cmd_element): New. * guile/guile.c (guile_cmd_element): New. (install_gdb_commands): Assign guile_cmd_element. * guile/guile.h (guile_cmd_element): New. * python/python.c (python_cmd_element): New. (_initialize_python): Assign python_cmd_element. * python/python.h (python_cmd_element): New. * tracepoint.c (while_stepping_cmd_element): New. (_initialize_tracepoint): Assign while_stepping_cmd_element. * tracepoint.h (while_stepping_cmd_element): New. gdb/testsuite/ChangeLog: PR python/23669 * gdb.python/python.exp: Test gdb.execute("show commands"). Fixed by the patch above. The gdb-8.2-branch branch has been updated. https://www.geometrydash.me/ These types of bugs are really troublesome specially if the component is python. Glad this has been resolved now. url: https://www.pestcontrolwestaucklandnz.kiwi/ Check this site for donwloading whatsapp gb: https://otherwhatsapp.com/ resolved! check this out https://www.gulfcoastwebsitedesign.com/locations/website-design-cypress-tx found a lot of useful information(In reply to John Sydow from comment #5) > The gdb-8.2-branch branch has been updated. > https://www.19216811ip.mobi/ Good work, well done. https://www.directics.com/artix7/ Definitely doesnt work. Please review. Glad that this has been fixed. https://mkminerals.com/ I was very encouraged to find this site. The reason being that this is such an informative post. Thanks for sharing! https://www.pergolaswollongong.com/ I was very encouraged to find this site. The reason being that this is such an informative post. Thanks for sharing! https://www.pergolaswollongong.com/ Thanks for the update. I need this command at the moment at https://www.drywallaugusta.com/ :) All the best! Thanks for resolving this. https://www.lynnlaw.com/practices/automobile-accidents/ Amazing creation man. Keep this up. https://www.maggardlaserart.com/ Mad genius. Thanks for clearing this up. https://www.gutterinstallationarvada.com/ (In reply to John Sydow from comment #5) > The gdb-8.2-branch branch has been updated. > https://www.geometrydash.me/ Good stuff. Thank you. https://www.gutterinstallationfortcollins.com/ |
With gdb 8.2: This command: (gdb) show commands 32 commands 33 commands 34 python gdb.execute("show commands") 35 python gdb.execute("show version") 36 python gdb.execute("show version") 37 python gdb.execute("show commands") 38 python gdb.execute("show commands") 39 help 40 show commands 41 show commands When executed with gdb.execute, doesn't work: (gdb) python gdb.execute("show commands") warning: bad breakpoint number at or near '0' GDB appears to try to run the "commands" command and complain about the lack of breakpoint number. With GDB master, it still tries to invoke the "commands" command, but the output is silent.