| Summary: | Libabigail thinks GLib broke ABI | ||
|---|---|---|---|
| Product: | libabigail | Reporter: | Mathieu Bridon <bochecha> |
| Component: | default | Assignee: | Dodji Seketeli <dodji> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | libabigail, maennich |
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Host: | Target: | ||
| Build: | Last reconfirmed: | 2018-09-17 00:00:00 | |
"bochecha at daitauha dot fr" <sourceware-bugzilla@sourceware.org> a écrit: > entity changed from 'volatile GObject' to 'typedef GObject' at > gobject.h:187:1 > type size hasn't changed [...] > Could this be a bug in libabigail, that this isn't considered a harmless > change? Yes, it is. I think we should flag this change as harmless. Thanks for pointing this out. > Yes, it is. I think we should flag this change as harmless. Actually, it seems like libabigail 1.4 actually flags this as harmless. But then it looks like I forgot to update the libabigail package in Fedora 28. The update should reach that distro soon, i.e: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0f1a9b9137. Sorry for the inconvenience. I can confirm this is fixed by libabigail 1.4, which marks this as a harmless change automatically. Resolved with 1.4 or later. |
Over at the Freedesktop-Sdk project, we're using abidiff to check for ABI breaks of our whole SDK. Updating GLib from 2.56. to 2.58, abidiff reports the following: Functions changes summary: 0 Removed, 1 Changed, 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 1 function with some indirect sub-type change: [C]'function void g_clear_object(volatile GObject**)' at gobject.c:3381:1 has some indirect sub-type changes: parameter 1 of type 'volatile GObject**' changed: in pointed to type 'volatile GObject*': in pointed to type 'volatile GObject' at gobject.h:187:1: entity changed from 'volatile GObject' to 'typedef GObject' at gobject.h:187:1 type size hasn't changed This was a deliberate change in GLib: https://gitlab.gnome.org/GNOME/glib/commit/2aacef39b1cfe4cc5eade704db05ffe1516be22e Could this be a bug in libabigail, that this isn't considered a harmless change?