Summary: | SEGFAULT in objdump.c on fuzzed PE32 executable | ||
---|---|---|---|
Product: | binutils | Reporter: | scottgriffy |
Component: | binutils | Assignee: | Not yet assigned to anyone <unassigned> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | nickc |
Priority: | P2 | ||
Version: | 2.27 | ||
Target Milestone: | --- | ||
Host: | Target: | ||
Build: | Last reconfirmed: | ||
Attachments: | The problem file |
Description
scottgriffy
2016-09-13 22:44:59 UTC
The master branch has been updated by Nick Clifton <nickc@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e6d042fe27102cb789407ccb2ec1663aa9c65129 commit e6d042fe27102cb789407ccb2ec1663aa9c65129 Author: Nick Clifton <nickc@redhat.com> Date: Wed Sep 14 15:32:01 2016 +0100 Fix seg-fault in objdump when run on a fuzzed PE binary. PR binutils/20605 * peicode.h (pe_bfd_read_buildid): Check that the Data Directory contains a valid size for the Debug directory. Hi Scott, Thanks for reporting this bug. I have checked in a patch to fix the problem. If you find any more bugs, please feel free to open a new PR. Or, if you find problems with my solution to this problem, please feel free to reopen this PR. Cheers Nick Hi Nick, I double checked your solution to make sure that it fixed the problem. Looks like it's working. It's putting the error you added into stderr when I run the same test that segfaulted before. Thanks, -Scott |