| Summary: | Testsuite ld-plugin/lto.exp fails | ||
|---|---|---|---|
| Product: | binutils | Reporter: | jb999 <jb999> |
| Component: | ld | Assignee: | Not yet assigned to anyone <unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hjl.tools |
| Priority: | P2 | ||
| Version: | 2.27 | ||
| Target Milestone: | 2.28 | ||
| Host: | Target: | ||
| Build: | Last reconfirmed: | ||
| Attachments: | Try this | ||
|
Description
jb999@gmx.de
2016-08-04 17:49:05 UTC
Hi H.J. Please could you look at this bug report: https://sourceware.org/bugzilla/show_bug.cgi?id=20436 It appears to be a direct consequence of your patch from 2016-04-21: * testsuite/lib/ld-lib.exp (check_lto_available): Return 1 on Linux with GCC 4.9 or newer. (check_lto_fat_available): Likewise. (check_lto_shared_available): Likewise. Cheers Nick PS. Incidentally, I could not find that entry in the ld/ChangeLog file. Was it omitted ? (In reply to Nick Clifton from comment #1) > Hi H.J. > > Please could you look at this bug report: > > https://sourceware.org/bugzilla/show_bug.cgi?id=20436 > > It appears to be a direct consequence of your patch from 2016-04-21: > > * testsuite/lib/ld-lib.exp (check_lto_available): Return 1 on > Linux with GCC 4.9 or newer. When there is a LTO bug in ld, check_lto_available will fail even if GCC supports LTO. We need to check if LTO is disabled. > (check_lto_fat_available): Likewise. > (check_lto_shared_available): Likewise. > > Cheers > Nick > > PS. Incidentally, I could not find that entry in the ld/ChangeLog file. > Was it omitted ? I missed it. Created attachment 9425 [details]
Try this
(In reply to H.J. Lu from comment #3) > Created attachment 9425 [details] > Try this The testsuite passes now, thanks. The master branch has been updated by H.J. Lu <hjl@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5ff559107a34a664abf7db01cc9db93e3597d466 commit 5ff559107a34a664abf7db01cc9db93e3597d466 Author: H.J. Lu <hjl.tools@gmail.com> Date: Tue Aug 9 16:41:12 2016 -0700 Skip LTO tests for --disable-plugin Don't run LTO tests if compiler is configured with --disable-plugin. PR ld/20436 * testsuite/lib/ld-lib.exp (check_gcc_plugin_enabled): New proc. (check_lto_available): Return 0 if check_gcc_plugin_enabled returns 0. (check_lto_fat_available): Likewise. (check_lto_shared_available): Likewise. Fixed for 2.28. The master branch has been updated by Nick Clifton <nickc@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7f6bf02d58c837d0a5f1e266058cc0e6bd6fc318 commit 7f6bf02d58c837d0a5f1e266058cc0e6bd6fc318 Author: Nick Clifton <nickc@redhat.com> Date: Thu Aug 11 10:22:41 2016 +0100 Avoid testsuite errors about missing compilers. PR ld/20436 * testsuite/lib/ld-lib.exp (check_gcc_plugin_enabled): When not testing remotely, check to see if target compiler is installed before trying to run it. The master branch has been updated by Alan Modra <amodra@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8be1e36919a884152d7115f4f4b8c0cfcf086a1f commit 8be1e36919a884152d7115f4f4b8c0cfcf086a1f Author: Alan Modra <amodra@gmail.com> Date: Thu Aug 11 23:42:05 2016 +0930 Fix ERROR: target-cc does not exist PR ld/20436 * testsuite/lib/ld-lib.exp (at_least_gcc_version): Don't ignore remote_exec status. (check_gcc_plugin_enabled): Likewise. |