| Summary: | dlopen with both RTLD_NOLOAD and RTLD_NODELETE causes a segmentation fault | ||
|---|---|---|---|
| Product: | glibc | Reporter: | Aurelien Jarno <aurelien> |
| Component: | dynamic-link | Assignee: | Not yet assigned to anyone <unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Flags: | fweimer:
security-
|
| Priority: | P2 | ||
| Version: | 2.23 | ||
| Target Milestone: | 2.25 | ||
| URL: | http://bugs.debian.org/817900 | ||
| Host: | Target: | ||
| Build: | Last reconfirmed: | ||
|
Description
Aurelien Jarno
2016-03-11 18:22:28 UTC
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via ead3cea7d8948113fe205243acbddbda609de5c9 (commit)
from 6b75ba1388bff6a81bad410d7318d385a043b3cb (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ead3cea7d8948113fe205243acbddbda609de5c9
commit ead3cea7d8948113fe205243acbddbda609de5c9
Author: Aurelien Jarno <aurelien@aurel32.net>
Date: Sat Sep 3 20:25:59 2016 +0200
Set NODELETE flag after checking for NULL pointer
The commit b632bdd3 moved the setting of the DF_1_NODELETE flag earlier
in the dl_open_worker function. However when calling dlopen with both
RTLD_NODELETE and RTLD_NOLOAD, the pointer returned by _dl_map_object is
NULL. This condition is checked just after setting the flag, while it
should be done before. Fix that.
Changelog:
[BZ #19810]
* elf/dl-open.c (dl_open_worker): Set DF_1_NODELETE flag later.
* elf/tst-noload.c: New test case.
* elf/Makefile (tests): Add tst-noload.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 7 +++
elf/Makefile | 3 +-
elf/dl-open.c | 12 +++---
stdio-common/tst-fmemopen4.c => elf/tst-noload.c | 52 +++++++++++----------
4 files changed, 42 insertions(+), 32 deletions(-)
copy stdio-common/tst-fmemopen4.c => elf/tst-noload.c (50%)
Fixed in commit ead3cea7d8948113fe205243acbddbda609de5c9 Please set the target milestone when marking a bug as fixed. (In reply to joseph@codesourcery.com from comment #3) > Please set the target milestone when marking a bug as fixed. Sorry, I didn't know about that, I will try to do that better. Also I don't know bugzilla very well, therefore I would appreciate some hint about how to to that. I am not able to edit or select the value, contrary to other fields. On Mon, 5 Sep 2016, aurelien at aurel32 dot net wrote: > Sorry, I didn't know about that, I will try to do that better. Also I don't > know bugzilla very well, therefore I would appreciate some hint about how to to > that. I am not able to edit or select the value, contrary to other fields. I've added you to the editbugs group. The target milestone field is used to produce the list of fixed bugs in the NEWS file, so should be set to the first mainline release with the fix. See: https://sourceware.org/glibc/wiki/Bugzilla%20Procedures (In reply to joseph@codesourcery.com from comment #5) > I've added you to the editbugs group. > > The target milestone field is used to produce the list of fixed bugs in > the NEWS file, so should be set to the first mainline release with the > fix. See: https://sourceware.org/glibc/wiki/Bugzilla%20Procedures Thanks, I have just done the change. |