Summary: | Systemtap translator putting in two probes for each probe point in the systemtap.base/library.exp tests | ||
---|---|---|---|
Product: | systemtap | Reporter: | William Cohen <wcohen> |
Component: | translator | Assignee: | Josh Stone <jistone> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jistone |
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Host: | Target: | ||
Build: | Last reconfirmed: |
Description
William Cohen
2015-12-14 20:35:32 UTC
A git bisect points to the following commit causing the failure: commit 1341a03cc550835d5ddab35bb9333e43bd623714 Author: Josh Stone <jistone@redhat.com> Date: Mon Nov 16 17:58:13 2015 -0800 Drop the string name from struct probe The name is only used occasionally, so saving the string is wasting space. It's simply "probe_"+index, so let's store the index as an identifier, and generate the name on the fly. This saves noticeable time and space when parsing large tapsets like qemu's. The probe locations got doubled up in that commit, when I refactored the copy constructor to use an initializer list. Fixed in commit 9ae080fa6846c74f01a28a9a62ab4c4f53846671. |