| Summary: | Frame filters do not display inlined functions | ||
|---|---|---|---|
| Product: | gdb | Reporter: | Jan Kratochvil <jan> |
| Component: | python | Assignee: | Not yet assigned to anyone <unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jan, kevin.pouget, tromey, tromey |
| Priority: | P2 | ||
| Version: | HEAD | ||
| Target Milestone: | 7.12 | ||
| Host: | Target: | ||
| Build: | Last reconfirmed: | ||
| Bug Depends on: | |||
| Bug Blocks: | 18566 | ||
| Attachments: | Fix+testcase | ||
|
Description
Jan Kratochvil
2015-06-20 17:52:19 UTC
I came up with this same patch. I don't see the indentation problem. Do I need to do something special to get it? Otherwise I plan to submit this soon. *** Bug 19225 has been marked as a duplicate of this bug. *** *** Bug 16219 has been marked as a duplicate of this bug. *** (In reply to Tom Tromey from comment #1) > I don't see the indentation problem. Do I need to do something > special to get it? I do not remember. If it works now then I am sure fine with it. The master branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d10153cfc6cb319a75ceb3e3d34ac30efa17e518 commit d10153cfc6cb319a75ceb3e3d34ac30efa17e518 Author: Tom Tromey <tom@tromey.com> Date: Wed Aug 3 08:27:56 2016 -0600 Avoid potential memory leak in find_frame_funname The PR 18565 thread pointed out that, if cp_remove_params can throw (we aren't quite sure), then find_frame_funname could leak some memory. This patch avoids any potential issue by rearranging some code in find_frame_funname. Built and regtested on x86-64 Fedora 24. 2016-08-03 Tom Tromey <tom@tromey.com> * stack.c (find_frame_funname): Avoid any possible leak in case cp_remove_params can throw. The master branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=282a0691a725d1f6653840728449adb297c8c856 commit 282a0691a725d1f6653840728449adb297c8c856 Author: Tom Tromey <tom@tromey.com> Date: Sun Jun 12 20:45:29 2016 -0600 PR python/18565 - make Frame.function work for inline frames PR python/18565 notes that calling frame filters don't work properly for inlined functions. This happens because Frame.function on an inline frame will yield the wrong result. This patch changes this code to use find_frame_funname instead, which handles inline frames properly. Built and regtested on x86-64 Fedora 24. 2016-08-03 Tom Tromey <tom@tromey.com> PR python/18565: * python/py-frame.c (frapy_function): Use find_frame_funname. 2016-08-03 Tom Tromey <tom@tromey.com> PR python/18565: * gdb.python/py-frame-inline.exp: Add Frame.function test. The gdb-7.12-branch branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d2ed2edaf76fc10505214290d04c3cf312acfbca commit d2ed2edaf76fc10505214290d04c3cf312acfbca Author: Tom Tromey <tom@tromey.com> Date: Wed Aug 3 08:27:56 2016 -0600 Avoid potential memory leak in find_frame_funname The PR 18565 thread pointed out that, if cp_remove_params can throw (we aren't quite sure), then find_frame_funname could leak some memory. This patch avoids any potential issue by rearranging some code in find_frame_funname. Built and regtested on x86-64 Fedora 24. 2016-08-03 Tom Tromey <tom@tromey.com> * stack.c (find_frame_funname): Avoid any possible leak in case cp_remove_params can throw. The gdb-7.12-branch branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ff4a25a115a0f477174eb0b4763d186a590c035a commit ff4a25a115a0f477174eb0b4763d186a590c035a Author: Tom Tromey <tom@tromey.com> Date: Sun Jun 12 20:45:29 2016 -0600 PR python/18565 - make Frame.function work for inline frames PR python/18565 notes that calling frame filters don't work properly for inlined functions. This happens because Frame.function on an inline frame will yield the wrong result. This patch changes this code to use find_frame_funname instead, which handles inline frames properly. Built and regtested on x86-64 Fedora 24. 2016-08-03 Tom Tromey <tom@tromey.com> PR python/18565: * python/py-frame.c (frapy_function): Use find_frame_funname. 2016-08-03 Tom Tromey <tom@tromey.com> PR python/18565: * gdb.python/py-frame-inline.exp: Add Frame.function test. Fixed. |