Bug 15366

Summary: Per C11 and C++11, <stdint.h> should not look at __STDC_LIMIT_MACROS or __STDC_CONSTANT_MACROS
Product: glibc Reporter: Richard Smith <richard>
Component: libcAssignee: Paul Pluzhnikov <ppluzhnikov>
Status: RESOLVED FIXED    
Severity: normal CC: drepper.fsp, fweimer, ondra, ppluzhnikov
Priority: P2 Flags: fweimer: security-
Version: unspecified   
Target Milestone: 2.18   
Host: Target:
Build: Last reconfirmed:
Project(s) to access: ssh public key:

Description Richard Smith 2013-04-13 00:32:50 UTC 
glibc's <stdint.h> follows C99, which says that in C++, certain macros should only be defined if __STDC_LIMIT_MACROS or __STDC_CONSTANT_MACROS is defined. However, the C++ committee decided that they didn't want this behavior, and explicitly overruled this in the C++11 standard (the first to provide <stdint.h>). Consequently C11 removed these rules. glibc has not been updated to follow the C11 rules, and still checks for those macros being defined in C++ mode.

C++ implementations are currently working around this by wrapping glibc's <stdint.h> with one which defines these macros first. These workarounds should not be necessary; glibc should simply not be checking for these macros. Fix would be to remove these lines from sysdeps/generic/stdint.h:

/* The ISO C99 standard specifies that in C++ implementations these
   macros should only be defined if explicitly requested.  */
#if !defined __cplusplus || defined __STDC_LIMIT_MACROS

... plus the corresponding #endif and the corresponding lines for __STDC_CONSTANT_MACROS.
Comment 1 Paul Pluzhnikov 2013-04-15 23:32:47 UTC 
Google ref: b/8607032
Proposed patch: http://sourceware.org/ml/libc-alpha/2013-04/msg00473.html
Comment 2 OndrejBilka 2013-05-21 14:17:33 UTC 
Was according to http://sourceware.org/ml/libc-alpha/2013-04/msg00677.html
commited.
Comment 3 Florian Weimer 2016-11-24 18:18:08 UTC 
commit 1ef74943ce2f114c78b215af57c2ccc72ccdb0b7
Author: Paul Pluzhnikov <ppluzhnikov@google.com>
Date:   Thu Apr 25 11:08:31 2013 -0700

    Get rid of __STDC_FORMAT_MACROS, __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS

This went into glibc 2.18.