Bug 1519

Summary: frysk.proc.TaskObserver.Terminated doesn't work
Product: frysk Reporter: Andrew Cagney <cagney>
Component: generalAssignee: Andrew Cagney <cagney>
Status: RESOLVED FIXED    
Severity: normal CC: pmuldoon, swagiaal
Priority: P1    
Version: unspecified   
Target Milestone: ---   
Host: Target:
Build: Last reconfirmed:
Bug Depends on: 1426, 1518, 1542, 1556, 1557    
Bug Blocks: 1553, 1364    

Description Andrew Cagney 2005-10-22 15:43:00 UTC
 
Comment 1 Andrew Cagney 2005-10-23 21:16:05 UTC
*** Bug 1518 has been marked as a duplicate of this bug. ***
Comment 2 Andrew Cagney 2005-10-24 01:10:51 UTC
Index: frysk-core/frysk/proc/ChangeLog
2005-10-23  Andrew Cagney  <cagney@redhat.com>

        * Proc.java: Delete .taskDestroyed.
        * TaskState.java: Replace Proc .taskDestroyed, with Task
        .notifyTerminated.
        * Task.java: Add .notifyTerminated.
        * TestTerminated.java, TestModify.java, TestExiting.java: Use
        TaskObserver .Terminated.
Comment 3 Andrew Cagney 2005-10-25 21:38:09 UTC
Tested thus:

unning testTerminateExit0(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminateExit47(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminateKillINT(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminateKillKILL(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminateKillHUP(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatingExit0(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatingExit47(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatingKillINT(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatingKillKILL(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatingKillHUP(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatedExit0(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatedExit47(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatedKillINT(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatedKillKILL(frysk.proc.TestTaskTerminateObserver) ...
Running testTerminatedKillHUP(frysk.proc.TestTaskTerminateObserver) ...

2005-10-25  Andrew Cagney  <cagney@redhat.com>

        * TestTaskTerminateObserver.java: Enable all tests.

        * TaskObservable.java: New file.
        * TestTaskTerminateObserver.java, TestTaskForkedObserver.java,
        TestTaskClonedObserver.java, TestProcGet.java, TestModify.java:
        Update.
        * TestLib.java: Make .TaskObserverBase abstract adding .updateTask
        method; have it register itself as a task-added observer.  Delete
        AddTaskObserver.
        * TaskState.java: Update .processRequestAddObserver, and
        .processRequestDeleteObserver to take a TaskObservable.
        * Task.java: Add .clonedObservers, .requestAddClonedObserver,
        requestDeleteClonedObserver, .attachedObservers,
        .requestAddAttachedObserver, .requestDeleteAttachedObserver,
        .forkedObservers, .requestAddForkedObserver,
        .requestDeleteForkedObserver, .terminatedObservers,
        .requestAddTerminatedObserver, .requestDeleteTerminatedObserver,
        .terminatingObservers, .requestAddTerminatingObserver,
        .requestDeleteTerminatingObserver, .execedObservers,
        .requestAddExecedObserver, .requestDeleteExecedObserver.  Make
        .requestAddObserver, and .requestDeleteObserver private.

2005-10-24  Andrew Cagney  <cagney@redhat.com>

        * TestTaskTerminateObserver.java: New.
        * TestExiting.java: Delete.
        * TestTerminated.java: Delete.

        * Action.java: New.  * TaskObserver.java: Change doc so that
        observers return Action.BLOCK to to block.
        * Task.java: Update .notifyCloned, .notifyAttached, .notifyForked,
        .notifyTerminated, .notifyTerminating, .notifyExeced; have them
        return the block count.
        * TestTerminated.java, TestTaskForkedObserver.java,
        TestTaskClonedObserver.java, TestProcGet.java, TestModify.java,
        TestLib.java, TestExiting.java, TaskState.java: Update.

Comment 4 Andrew Cagney 2005-10-25 21:38:59 UTC
*** Bug 1523 has been marked as a duplicate of this bug. ***