Summary: | readelf.c:403:3: error: unknown type name 'mbstate_t' | ||
---|---|---|---|
Product: | binutils | Reporter: | John David Anglin <danglin> |
Component: | binutils | Assignee: | Not yet assigned to anyone <unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | antoine64leca, jan.smets, nickc |
Priority: | P2 | ||
Version: | 2.24 | ||
Target Milestone: | 2.24 | ||
Host: | hppa1.1-hp-hp10.20 | Target: | hppa1.1-hp-hp10.20 |
Build: | hppa1.1-hp-hp10.20 | Last reconfirmed: | |
Attachments: | Proposed patch |
Description
John David Anglin
2012-10-28 06:41:56 UTC
Created attachment 6710 [details]
Proposed patch
Hi John, Please could you try out the uploaded patch and let me know if it works for you. Cheers Nick CVSROOT: /cvs/src Module name: src Changes by: nickc@sourceware.org 2012-10-30 12:44:58 Modified files: bfd : ChangeLog elf-bfd.h elf32-arm.c elflink.c binutils : ChangeLog bfdtest1.c config.in configure configure.in readelf.c elfcpp : ChangeLog arm.h gas/doc : as.texinfo gold : ChangeLog arm.cc include/elf : ChangeLog arm.h ld/testsuite : ChangeLog ld/testsuite/ld-arm: arm-elf.exp Log message: bfd: * elf32-arm.c (elf32_arm_print_private_bfd_data): Recognise and display the new ARM hard-float/soft-float ABI flags for EABI_VER5 (elf32_arm_post_process_headers): Add the hard-float/soft-float ABI flag as appropriate for ET_DYN/ET_EXEC in EABI_VER5. binutils: * readelf.c (decode_ARM_machine_flags): Recognise and display the new ARM hard-float/soft-float ABI flags for EABI_VER5. Split out the code for EABI_VER4 and EABI_VER5 to allow this. elfcpp: * arm.h: New enum for EABI soft- and hard-float flags. gold: * gold.cc (Target_arm::do_adjust_elf_header): Add the hard-float/soft-float ABI flag as appropriate for ET_DYN/ET_EXEC in EABI_VER5. include: * elf/arm.h (EF_ARM_ABI_FLOAT_SOFT): New define. (EF_ARM_ABI_FLOAT_HARD): Likewise. ld/testsuite: * ld-arm/eabi-hard-float.s: New test source. * ld-arm/eabi-soft-float.s: New test source. * ld-arm/eabi-hard-float.d: New test. * ld-arm/eabi-soft-float.d: New test. * ld-arm/eabi-soft-float-ABI4.d: New test. * ld-arm/eabi-soft-float-r.d: New test. * ld-arm/arm-elf.xp: Use the new tests. binutils: PR binutils/14779 * configure.in: Add checks for wchar.h and mbstate_t. * config.in: Regenerate. * configure: Regenerate. * readelf.c: Conditionally include wchar.h. (print_symbol): Conditionally use mbstate_t. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=src&r1=1.5835&r2=1.5836 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf-bfd.h.diff?cvsroot=src&r1=1.348&r2=1.349 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-arm.c.diff?cvsroot=src&r1=1.300&r2=1.301 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elflink.c.diff?cvsroot=src&r1=1.455&r2=1.456 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/ChangeLog.diff?cvsroot=src&r1=1.1950&r2=1.1951 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/bfdtest1.c.diff?cvsroot=src&r1=1.1&r2=1.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/config.in.diff?cvsroot=src&r1=1.39&r2=1.40 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/configure.diff?cvsroot=src&r1=1.152&r2=1.153 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/configure.in.diff?cvsroot=src&r1=1.113&r2=1.114 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/readelf.c.diff?cvsroot=src&r1=1.583&r2=1.584 http://sourceware.org/cgi-bin/cvsweb.cgi/src/elfcpp/ChangeLog.diff?cvsroot=src&r1=1.49&r2=1.50 http://sourceware.org/cgi-bin/cvsweb.cgi/src/elfcpp/arm.h.diff?cvsroot=src&r1=1.6&r2=1.7 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/doc/as.texinfo.diff?cvsroot=src&r1=1.259&r2=1.260 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/ChangeLog.diff?cvsroot=src&r1=1.984&r2=1.985 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/arm.cc.diff?cvsroot=src&r1=1.156&r2=1.157 http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/elf/ChangeLog.diff?cvsroot=src&r1=1.448&r2=1.449 http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/elf/arm.h.diff?cvsroot=src&r1=1.45&r2=1.46 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1614&r2=1.1615 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-arm/arm-elf.exp.diff?cvsroot=src&r1=1.97&r2=1.98 Hi Nick,
On 10/30/2012 8:03 AM, nickc at redhat dot com wrote:
> Please could you try out the uploaded patch and let me know if it works for
> you.
The patch works fine.
I'm going to retest removing --disable-werror. Think there are
a couple of unrelated warnings that need fixing.
Thanks,
Dave
On 30-Oct-12, at 8:45 AM, cvs-commit at gcc dot gnu.org wrote: > binutils: > PR binutils/14779 > * configure.in: Add checks for wchar.h and mbstate_t. > * config.in: Regenerate. > * configure: Regenerate. > * readelf.c: Conditionally include wchar.h. > (print_symbol): Conditionally use mbstate_t. Bug is also present in 2.23. -- John David Anglin dave.anglin@bell.net CVSROOT: /cvs/src Module name: src Branch: binutils-2_23-branch Changes by: nickc@sourceware.org 2012-10-31 11:45:12 Modified files: binutils : ChangeLog config.in configure configure.in readelf.c Log message: PR binutils/14779 * configure.in: Add checks for wchar.h and mbstate_t. * config.in: Regenerate. * configure: Regenerate. * readelf.c: Conditionally include wchar.h. (print_symbol): Conditionally use mbstate_t. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.1925.2.5&r2=1.1925.2.6 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/config.in.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.38.2.1&r2=1.38.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/configure.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.148&r2=1.148.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/configure.in.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.111&r2=1.111.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/readelf.c.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.578.2.2&r2=1.578.2.3 I think this broke cross compilation for i386-mingw (gcc 3.4) readelf.o: In function `print_symbol': binutils-2.23.2/binutils/readelf.c:469: undefined reference to `_mbrtowc' (In reply to Jan Smets from comment #7) > I think this broke cross compilation for i386-mingw (gcc 3.4) > > readelf.o: In function `print_symbol': > binutils-2.23.2/binutils/readelf.c:469: undefined reference to `_mbrtowc' Solved for me. As made clear in MingW's include/wchar.h /* These are resolved by -lmingwex. Alternatively, they can be resolved by adding -lmsvcp60 to your command line, which will give you the VC++ versions of these functions. If you want the latter and don't have msvcp60.dll in your windows system directory, you can easily obtain it with a search from your favorite search engine. */ Earlier (obsolete) versions of Mingw-rt did not mention -lmingwex. Adding LIBS=-lmsvcp60 in the binutils/Makefile did the job for me. Fixed. |