Bug 13456

Summary: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_epoll_create1()
Product: systemtap Reporter: Mark Wielaard <mark>
Component: tapsetsAssignee: Unassigned <systemtap>
Status: RESOLVED FIXED    
Severity: normal CC: dsmith
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Host: Target:
Build: Last reconfirmed:
Bug Depends on: 11424    
Bug Blocks:    

Description Mark Wielaard 2011-11-29 19:32:16 UTC
The corresponding tapset/syscalls.stp has:

probe syscall.epoll_create = kernel.function("sys_epoll_create1").call !,
                             kernel.function("sys_epoll_create").call ?
Comment 1 David Smith 2011-11-30 18:43:42 UTC
The reason why it is done this way in syscalls.stp is that in the kernel
sys_epoll_create is just a wrapper around sys_epoll_create1.  This way we
ignore the sys_epoll_create call, and only catch the sys_epoll_create1 call on
kernels with sys_epoll_create1.

Unfortunately, as bug #11424 notes, '!' (optional and sufficient) doesn't work
for kprobe.function probes.  So, the above logic will be difficult to duplicate
in tapset/nd_syscalls.stp.
Comment 2 David Smith 2012-07-20 19:25:18 UTC
Now that bug #11424 and bug #14378 are fixed, this bug can be addressed.

Fixed in commit 3b9ac30.