| Summary: | silence gcc errors in hurd/intr-msg.c, sysdeps/mach/hurd/{setitimer.c,profil.c,ioctl.c} | ||
|---|---|---|---|
| Product: | glibc | Reporter: | Thomas Schwinge <tschwinge> |
| Component: | hurd | Assignee: | Roland McGrath <roland> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ams, glibc-bugs |
| Priority: | P2 | Flags: | fweimer:
security-
|
| Version: | 2.3.5 | ||
| Target Milestone: | --- | ||
| Host: | i586-pc-gnu | Target: | i586-pc-gnu |
| Build: | i586-pc-gnu | Last reconfirmed: | |
| Bug Depends on: | |||
| Bug Blocks: | 852 | ||
| Attachments: |
This is an updated patch.
The remaining bits. |
||
|
Description
Thomas Schwinge
2005-08-26 23:01:44 UTC
Created attachment 660 [details]
This is an updated patch.
I fixed the patch for ioctl.c and added some casts to make warnings from gcc go
away.
Subject: Bug 1252 CVSROOT: /cvs/glibc Module name: libc Changes by: roland@sources.redhat.com 2005-10-16 10:32:15 Modified files: sysdeps/mach/hurd: setitimer.c profil.c Log message: 2005-08-05 Alfred M. Szmidt <ams@gnu.org> [BZ #1252] * sysdeps/mach/hurd/setitimer.c (restart_itimer): Move static fn forward decl out of function body. * sysdeps/mach/hurd/profil.c: Likewise. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/setitimer.c.diff?cvsroot=glibc&r1=1.22&r2=1.23 http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/profil.c.diff?cvsroot=glibc&r1=1.10&r2=1.11 Subject: Bug 1252 CVSROOT: /cvs/glibc Module name: libc Branch: glibc-2_3-branch Changes by: roland@sources.redhat.com 2005-10-16 10:33:13 Modified files: sysdeps/mach/hurd: setitimer.c profil.c Log message: 2005-08-05 Alfred M. Szmidt <ams@gnu.org> [BZ #1252] * sysdeps/mach/hurd/setitimer.c (restart_itimer): Move static fn forward decl out of function body. * sysdeps/mach/hurd/profil.c: Likewise. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/setitimer.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.22&r2=1.22.6.1 http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/profil.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.10&r2=1.10.4.1 I put in the correct parts. The intr-msg.c et al changes should cast to void * to do arithmetic and then not need extra casts back. Subject: Re: silence gcc errors in hurd/intr-msg.c, sysdeps/mach/hurd/{setitimer.c,profil.c,ioctl.c}
On Sun, Oct 16, 2005 at 10:34:39AM -0000, roland at gnu dot org wrote:
> I put in the correct parts. The intr-msg.c et al changes should cast to void *
> to do arithmetic and then not need extra casts back.
I attached a thusly updated patch.
Created attachment 715 [details]
The remaining bits.
Subject: Bug 1252 CVSROOT: /cvs/glibc Module name: libc Changes by: roland@sources.redhat.com 2005-10-23 00:43:15 Modified files: hurd : intr-msg.c sysdeps/mach/hurd: ioctl.c Log message: 2005-10-17 Thomas Schwinge <tschwinge@gnu.org> [BZ #1252] * hurd/intr-msg.c (_hurd_intr_rpc_mach_msg): Don't use ?: as lvalue. * sysdeps/mach/hurd/ioctl.c (__ioctl): Likewise. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/hurd/intr-msg.c.diff?cvsroot=glibc&r1=1.16&r2=1.17 http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/ioctl.c.diff?cvsroot=glibc&r1=1.50&r2=1.51 Subject: Bug 1252 CVSROOT: /cvs/glibc Module name: libc Branch: glibc-2_3-branch Changes by: roland@sources.redhat.com 2005-10-23 00:55:47 Modified files: hurd : intr-msg.c sysdeps/mach/hurd: ioctl.c Log message: 2005-10-17 Thomas Schwinge <tschwinge@gnu.org> [BZ #1252] * hurd/intr-msg.c (_hurd_intr_rpc_mach_msg): Don't use ?: as lvalue. * sysdeps/mach/hurd/ioctl.c (__ioctl): Likewise. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/hurd/intr-msg.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.16&r2=1.16.4.1 http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/ioctl.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.50&r2=1.50.4.1 Changes are on both branches. Please verify everything is good. This bug should be fixed in the 2.3.6 release just made. |