Summary: | search_simple_memory miscalculates its read address for multiple search chunks | ||
---|---|---|---|
Product: | gdb | Reporter: | Chris Mears <chris> |
Component: | gdb | Assignee: | Not yet assigned to anyone <unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gdb-prs |
Priority: | P3 | ||
Version: | 7.0 | ||
Target Milestone: | 7.1 | ||
Host: | Target: | ||
Build: | Last reconfirmed: |
Description
Chris Mears
2009-10-15 15:31:10 UTC
Thanks. Pasting here the example you showed on IRC: (gdb) find /b 0xcaa6000, 0x0caa7000, 'B', 'u', 'r', 'n', 'e', 'r' 0xcaa6324 <--- this one is correct 1 pattern found. (gdb) find /b 0xbaa6000, 0x0caa7000, 'B', 'u', 'r', 'n', 'e', 'r' ^^^^^^^^^--- lowered the start address 0xc9197d2 \ 0xc91985c \_ no mention of 0xcaa6324 anymore ): 0xc91993c / 0xca98fac / 4 patterns found. Subject: Bug 10783 CVSROOT: /cvs/src Module name: src Changes by: sandra@sourceware.org 2009-10-29 20:12:26 Modified files: gdb : ChangeLog target.c gdb/gdbserver : ChangeLog server.c Log message: 2009-10-29 Sandra Loosemore <sandra@codesourcery.com> PR gdb/10783 gdb/ * target.c (simple_search_memory): Correct read_addr initialization in loop for searching subsequent chunks. gdb/gdbserver/ * server.c (handle_search_memory_1): Correct read_addr initialization in loop for searching subsequent chunks. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.11014&r2=1.11015 http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/target.c.diff?cvsroot=src&r1=1.230&r2=1.231 http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/ChangeLog.diff?cvsroot=src&r1=1.294&r2=1.295 http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/server.c.diff?cvsroot=src&r1=1.103&r2=1.104 I've checked in the patch attached to this message. As noted, the bug was also present in the target-side gdbserver logic. http://sourceware.org/ml/gdb-patches/2009-10/msg00691.html |