Attachment 14306 Details for Bug 29472 – Submit A Patch for 29472, bug fix

[patch] Submit A Patch for 29472, bug fix

0002-Bug-fix-Temp-string-object-lifecycle-too-short.patch (text/plain), 1.06 KB, created by Ryan Goldberg on 2022-08-31 14:52:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ryan Goldberg

Created: 2022-08-31 14:52:10 UTC

Size: 1.06 KB

patch

obsolete

>From b3e4bed7af1010e6959c12c94eaadd85dcef93f1 Mon Sep 17 00:00:00 2001
>From: Ryan Goldberg <rgoldber@redhat.com>
>Date: Wed, 31 Aug 2022 10:45:35 -0400
>Subject: [PATCH 2/2] Bug fix: Temp string object lifecycle too short
>
>---
> debuginfod/debuginfod.cxx | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
>index ee636a6f..f498762a 100644
>--- a/debuginfod/debuginfod.cxx
>+++ b/debuginfod/debuginfod.cxx
>@@ -2516,10 +2516,9 @@ handler_cb (void * /*cls*/,
>           (void) pthread_setname_np (pthread_self(), "mhd-metadata");
> #endif
> 
>-          const char* path_escaped = url_copy.substr(slash1+1).c_str();
>-
>-          string path = curl_unescape(path_escaped, strlen(path_escaped));
>+          string path_escaped = url_copy.substr(slash1+1);
> 
>+          string path = curl_unescape(path_escaped.c_str(), path_escaped.size());
>           artifacttype = "metadata";
>           inc_metric("http_requests_total", "type", artifacttype);
>           r = handle_metadata(connection, path, &http_size);
>-- 
>2.37.2
>

Actions: View | Diff

Attachments on bug 29472: 14289 | 14306 | 14310