Attachment 12116 Details for Bug 25265 – Fix invalid prototype in autoconf-stack-trace-save-regs.c test

[patch] Fix invalid prototype in autoconf-stack-trace-save-regs.c test

0001-Fix-the-runtime-s-detection-of-struct-stack_trace-on.patch (text/plain), 1.20 KB, created by Craig Ringer on 2019-12-10 06:51:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Craig Ringer

Created: 2019-12-10 06:51:17 UTC

Size: 1.20 KB

patch

obsolete

>From bca82948f49e0d633921ea90180cdeef81afaf6b Mon Sep 17 00:00:00 2001
>From: Craig Ringer <craig@2ndquadrant.com>
>Date: Tue, 10 Dec 2019 14:40:14 +0800
>Subject: [PATCH] Fix the runtime's detection of struct stack_trace on kernel
> 5.3
>
>Kernel 5.2 changed the API around stack trace access. "struct stack_trace"
>went away. systemtap already detects this with a configure-like test it runs
>for each module runtime build, runtime/linux/autoconf-stack-trace-save-regs.c .
>
>But systemtap's -Werror enables -Werror=strict-prototypes, causing this test to
>fail since it declares `int foo()` which in C is "foo() with no prototype" and
>not equivalent to "foo(void)".
>
>Fix the function definition.
>
>Fix bug #25265
>---
> runtime/linux/autoconf-stack-trace-save-regs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/runtime/linux/autoconf-stack-trace-save-regs.c b/runtime/linux/autoconf-stack-trace-save-regs.c
>index 8bf33391f..1fd515f8f 100644
>--- a/runtime/linux/autoconf-stack-trace-save-regs.c
>+++ b/runtime/linux/autoconf-stack-trace-save-regs.c
>@@ -1,6 +1,6 @@
> #include <linux/stacktrace.h>
> 
>-unsigned int foo ()
>+unsigned int foo (void)
> {
>         unsigned long e[10];
>         struct pt_regs* r = 0;
>-- 
>2.23.0
>

Actions: View | Diff

Attachments on bug 25265: 12116