commit 652c50a2541d703fa1fccc04e7b23da06e0dd177 Author: Joel Brobecker Date: Thu Dec 3 14:49:21 2009 -0800 Use ../libiconv/[...]/libiconv.a instgead of using -liconv. On Tru64, we noticed that there is a problem with linking against the in-tree libiconv when available: The linker does not recognize archives as libraries when linking with -liconv. So, we have to use the path/to/libiconv/lib/libconv.a explicitly on the command line instead. Since the latter should work on all platforms, we now always use the .a when linking with the in-tree libiconv. gdb/ * acinclude.m4: Link against in-tree libiconv by adding libiconv.a to the LIBS instead of using -liconv. * configure: Regenerate. diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 index af4639b..3684c18 100644 --- a/gdb/acinclude.m4 +++ b/gdb/acinclude.m4 @@ -184,7 +184,7 @@ AC_DEFUN([AM_ICONV], done ]) - BUILD_LIBICONV_LIBDIR="-L../libiconv/lib/.libs -L../libiconv/lib/_libs" + BUILD_LIBICONV_LIBDIRS="../libiconv/lib/.libs ../libiconv/lib/_libs" BUILD_LIBICONV_INCLUDE="-I../libiconv/include" AC_CACHE_CHECK(for iconv, am_cv_func_iconv, [ @@ -195,20 +195,26 @@ AC_DEFUN([AM_ICONV], # If libiconv is part of the build tree, then try using it over # any system iconv. if test -d ../libiconv; then - am_save_LIBS="$LIBS" - am_save_CPPFLAGS="$CPPFLAGS" - LIBS="$LIBS $BUILD_LIBICONV_LIBDIR -liconv" - CPPFLAGS="$CPPFLAGS $BUILD_LIBICONV_INCLUDE" - AC_TRY_LINK([#include + for lib_dir in $BUILD_LIBICONV_LIBDIRS; do + am_save_LIBS="$LIBS" + am_save_CPPFLAGS="$CPPFLAGS" + LIBS="$LIBS $lib_dir/libiconv.a" + CPPFLAGS="$CPPFLAGS $BUILD_LIBICONV_INCLUDE" + AC_TRY_LINK([#include #include ], - [iconv_t cd = iconv_open("",""); - iconv(cd,NULL,NULL,NULL,NULL); - iconv_close(cd);], - am_cv_use_build_libiconv=yes - am_cv_lib_iconv=yes - am_cv_func_iconv=yes) - LIBS="$am_save_LIBS" - CPPFLAGS="$am_save_CPPFLAGS" + [iconv_t cd = iconv_open("",""); + iconv(cd,NULL,NULL,NULL,NULL); + iconv_close(cd);], + am_cv_use_build_libiconv=yes + am_cv_lib_iconv=yes + am_cv_func_iconv=yes) + LIBS="$am_save_LIBS" + CPPFLAGS="$am_save_CPPFLAGS" + if test "$am_cv_use_build_libiconv" = "yes"; then + BUILD_LIBICONV_LIBDIR=$lib_dir + break + fi + done fi # Next, try to find iconv in libc. @@ -253,7 +259,8 @@ AC_DEFUN([AM_ICONV], LIBICONV_INCLUDE= fi if test "$am_cv_use_build_libiconv" = yes; then - LIBICONV_LIBDIR="$BUILD_LIBICONV_LIBDIR" + LIBICONV="$BUILD_LIBICONV_LIBDIR/libiconv.a" + LIBICONV_LIBDIR="" LIBICONV_INCLUDE="$BUILD_LIBICONV_INCLUDE" fi CPPFLAGS="$CPPFLAGS $LIBICONV_INCLUDE" diff --git a/gdb/configure b/gdb/configure index e74b64f..de8de91 100755 --- a/gdb/configure +++ b/gdb/configure @@ -8316,7 +8316,7 @@ if test "${with_libiconv_prefix+set}" = set; then : fi - BUILD_LIBICONV_LIBDIR="-L../libiconv/lib/.libs -L../libiconv/lib/_libs" + BUILD_LIBICONV_LIBDIRS="../libiconv/lib/.libs ../libiconv/lib/_libs" BUILD_LIBICONV_INCLUDE="-I../libiconv/include" { $as_echo "$as_me:${as_lineno-$LINENO}: checking for iconv" >&5 @@ -8332,11 +8332,12 @@ else # If libiconv is part of the build tree, then try using it over # any system iconv. if test -d ../libiconv; then - am_save_LIBS="$LIBS" - am_save_CPPFLAGS="$CPPFLAGS" - LIBS="$LIBS $BUILD_LIBICONV_LIBDIR -liconv" - CPPFLAGS="$CPPFLAGS $BUILD_LIBICONV_INCLUDE" - cat confdefs.h - <<_ACEOF >conftest.$ac_ext + for lib_dir in $BUILD_LIBICONV_LIBDIRS; do + am_save_LIBS="$LIBS" + am_save_CPPFLAGS="$CPPFLAGS" + LIBS="$LIBS $lib_dir/libiconv.a" + CPPFLAGS="$CPPFLAGS $BUILD_LIBICONV_INCLUDE" + cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ #include #include @@ -8344,21 +8345,26 @@ int main () { iconv_t cd = iconv_open("",""); - iconv(cd,NULL,NULL,NULL,NULL); - iconv_close(cd); + iconv(cd,NULL,NULL,NULL,NULL); + iconv_close(cd); ; return 0; } _ACEOF if ac_fn_c_try_link "$LINENO"; then : am_cv_use_build_libiconv=yes - am_cv_lib_iconv=yes - am_cv_func_iconv=yes + am_cv_lib_iconv=yes + am_cv_func_iconv=yes fi rm -f core conftest.err conftest.$ac_objext \ conftest$ac_exeext conftest.$ac_ext - LIBS="$am_save_LIBS" - CPPFLAGS="$am_save_CPPFLAGS" + LIBS="$am_save_LIBS" + CPPFLAGS="$am_save_CPPFLAGS" + if test "$am_cv_use_build_libiconv" = "yes"; then + BUILD_LIBICONV_LIBDIR=$lib_dir + break + fi + done fi # Next, try to find iconv in libc. @@ -8432,7 +8438,8 @@ $as_echo "$am_cv_func_iconv" >&6; } LIBICONV_INCLUDE= fi if test "$am_cv_use_build_libiconv" = yes; then - LIBICONV_LIBDIR="$BUILD_LIBICONV_LIBDIR" + LIBICONV="$BUILD_LIBICONV_LIBDIR/libiconv.a" + LIBICONV_LIBDIR="" LIBICONV_INCLUDE="$BUILD_LIBICONV_INCLUDE" fi CPPFLAGS="$CPPFLAGS $LIBICONV_INCLUDE"