[binutils-gdb] gdb/testsuite: fix gdb.base/ui-redirect.exp pattern (gdb/26532)

Simon Marchi simark@sourceware.org
Tue Aug 25 15:07:48 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2bc19622c9e74655151674661b77af52e1e064f8

commit 2bc19622c9e74655151674661b77af52e1e064f8
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Tue Aug 25 11:06:27 2020 -0400

    gdb/testsuite: fix gdb.base/ui-redirect.exp pattern (gdb/26532)
    
    Commit 1eb8556f5a8b ("gdb: add infrun_debug_printf macro") changed the
    debug output format for `set debug infrun 1`.  It broke test
    gdb.base/ui-redirect.exp, which I missed:
    
        FAIL: gdb.base/ui-redirect.exp: debugging: continue
    
    Fix it by adjusting the pattern in the test to the new reality.
    
    gdb/testsuite/ChangeLog:
    
            PR gdb/26532
            * gdb.base/ui-redirect.exp: Update pattern.
    
    Change-Id: Ie8a8f6675e35a0cab55109b1534b44eb51baec9d

Diff:
---
 gdb/testsuite/ChangeLog                | 5 +++++
 gdb/testsuite/gdb.base/ui-redirect.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 9a7ffc528dd..2ec908496c5 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-08-25  Simon Marchi  <simon.marchi@efficios.com>
+
+	PR gdb/26532
+	* gdb.base/ui-redirect.exp: Update pattern.
+
 2020-08-25  Gary Benson <gbenson@redhat.com>
 
 	* gdb.dwarf2/dw2-dir-file-name.exp: Use system assembler
diff --git a/gdb/testsuite/gdb.base/ui-redirect.exp b/gdb/testsuite/gdb.base/ui-redirect.exp
index e1e6a7b0a08..ef0a79178c7 100644
--- a/gdb/testsuite/gdb.base/ui-redirect.exp
+++ b/gdb/testsuite/gdb.base/ui-redirect.exp
@@ -117,7 +117,7 @@ with_test_prefix "debugging" {
     gdb_test "set debug infrun 1"
     gdb_test "set logging on" \
     "Copying output to /dev/null.*Copying debug output to /dev/null\\."
-    gdb_test "continue" "Continuing.*infrun:.*infrun:.*Breakpoint \[0-9\]+, foo.*"
+    gdb_test "continue" {Continuing.*\[infrun\] .*\[infrun\] .*Breakpoint [0-9]+, foo.*}
     gdb_test "set debug infrun 0"
     gdb_test "set logging off" "Done logging to /dev/null\\."
     gdb_test "help" "List of classes of commands:.*"


More information about the Gdb-cvs mailing list