[binutils-gdb] gdb/testsuite: Use 'array unset' instead of just 'unset'

Andrew Burgess aburgess@sourceware.org
Tue Aug 4 14:56:34 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=10c381b53f8d0295287b8205f170dfedd953993b

commit 10c381b53f8d0295287b8205f170dfedd953993b
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Tue Aug 4 12:13:37 2020 +0100

    gdb/testsuite: Use 'array unset' instead of just 'unset'
    
    In the check-test-names.exp library 'unset' was being used to unset an
    array variable.  Though this seems to work fine on tcl 8.6, it was
    discovered on a CentOS 7.8.2003 machine, running tcl 8.5, that this
    doesn't work and 'array unset' should be used instead.
    
    Using 'array unset' should work fine for newer and older versions of
    tcl (since 8.3, releases ~2000).
    
    gdb/testsuite/ChangeLog:
    
            * lib/check-test-names.exp (do_reset_vars): Use 'array unset' to
            unset the array variable.

Diff:
---
 gdb/testsuite/ChangeLog                | 5 +++++
 gdb/testsuite/lib/check-test-names.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 1e1b702ec6d..38cc7be47e6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-08-04  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* lib/check-test-names.exp (do_reset_vars): Use 'array unset' to
+	unset the array variable.
+
 2020-08-03  Tom de Vries  <tdevries@suse.de>
 
 	PR symtab/26333
diff --git a/gdb/testsuite/lib/check-test-names.exp b/gdb/testsuite/lib/check-test-names.exp
index 4c0fde6e4ea..d72de3cf821 100644
--- a/gdb/testsuite/lib/check-test-names.exp
+++ b/gdb/testsuite/lib/check-test-names.exp
@@ -150,7 +150,7 @@ namespace eval ::CheckTestNames {
 
 	CheckTestNames::reset_vars
 
-	unset all_test_names
+	array unset all_test_names
 	foreach nm {paths duplicates} {
 	    set counts($nm,count) 0
 	}


More information about the Gdb-cvs mailing list