patch 3/3 debuginfod client interruptability

Mark Wielaard mark@klomp.org
Tue Nov 19 12:58:00 GMT 2019


Hi,

On Sun, 2019-11-17 at 21:50 -0500, Frank Ch. Eigler wrote:
> > Attached is a variant that adds debuginfod_begin and debuginfo_end
> > (names matching elf/dwarf_begin/end) and adds a debuginfod_client
> > handle to each other function.
> 
> Sure, if you like.

OK, I rebased on the debuginfod-submit branch and added documentation
(see attached).

>   Would you be sympathetic to supporting a
> client=NULL entrypoint to the lookup functions, ergo no begin/end, for
> applications that don't want a progressfn callback?  That way the
> simple case looks simple.

I think it is better to be consistent and always require a valid client
connection handle for the reasons that Pedro gave.

> > diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
> >  
> > +static debuginfod_client *client;
> 
> Note that multiple http webapi handling threads may make
> federated debuginfod calls concurrently.  Is it your idea
> that they share a single client object?

No, it would be better to give every thread it own handle.
The attached patch does that.

All patches are also on 
https://code.wildebeest.org/git/user/mjw/elfutils/log/?h=debuginfod-client-context

If you think those patches are ok I can squash them and add them to the
debuginfod-submit branch.

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-update-documentation-for-client-connection-handle-us.patch
Type: text/x-patch
Size: 4845 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/elfutils-devel/attachments/20191119/fef98361/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-debuginfod-create-a-client-connection-handle-for-eac.patch
Type: text/x-patch
Size: 2169 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/elfutils-devel/attachments/20191119/fef98361/attachment-0001.bin>


More information about the Elfutils-devel mailing list