[PATCH V2 0/2] Add C-SKY support

Mark Wielaard mark@klomp.org
Mon Jun 24 22:26:00 GMT 2019


Hi,

On Wed, 2019-04-17 at 14:41 +0800, Mao Han wrote:
> I'v just spent sometime debuging this. Core dump backtrace on C-SKY
> seems
> can't be supported with current generic routine. DWARF register order is
> different from the order in core notes. The initialization of frame
> registers is totally incorrect. As the comment says some fix with
> private function is needed.

My apologies for taking so long to reply. I am looking at your latest
patch and found this discussion. It will take me a bit to properly
review everything. But I didn't forget.

> BTW the error log seems incorrect here.
> 
> diff --git a/src/stack.c b/src/stack.c
> index c5f347e..4daabce 100644
> --- a/src/stack.c
> +++ b/src/stack.c
> @@ -608,7 +608,7 @@ parse_opt (int key, char *arg __attribute__
> ((unused)),
>        if (core != NULL)
>         {
>           if (dwfl_core_file_attach (dwfl, core) < 0)
> -           error (EXIT_BAD, 0, "dwfl_core_file_report: %s",
> dwfl_errmsg (-1));
> +           error (EXIT_BAD, 0, "dwfl_core_file_attach: %s",
> dwfl_errmsg (-1));
>         }
>  
>        /* Makes sure we are properly attached.  */

You are totally correct. I have installed the attached patch.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-stack-Fix-error-message-when-dwfl_core_file_attach-f.patch
Type: text/x-patch
Size: 1241 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/elfutils-devel/attachments/20190624/e615fea1/attachment.bin>


More information about the Elfutils-devel mailing list