[Bug general/23914] Add --disable-werror to ./configure support (example trigger: CFLAGS=-Og

[slyfox at inbox dot ru]

https://sourceware.org/bugzilla/show_bug.cgi?id=23914

--- Comment #4 from Sergei Trofimovich <slyfox at inbox dot ru> ---
(In reply to Mark Wielaard from comment #3)
> (In reply to Sergei Trofimovich from comment #2)
> > Gentoo allows users to control CC and CFLAGS and thus the space for getting
> > a warning is wide. People frequently use things like -Wcast-qual or other
> > high signal-to-noise flags for their purposes.
> 
> If they do and don't care about the warnings, then why don't they simply add
> -Wno-error too?

I'm not sure it works when CFLAGS are set system-wide (instead of per-package
basis). A few packages do feature testing with -Werror set and insist on keep
doing it.

Gentoo can pass CFLAGS="-Wno-error ${USER_CFLAGS}" to elfutils package
unconditionally as part of a build script if it's a supported configuration
upstream. It should be good enough alternative to --disable-werror.

> > 2. CFLAGS="-g -O2 -Wstack-protector"
> > 
> >     CC       readelf.o
> >   readelf.c: In function 'open_input_section':
> >   readelf.c:581:1: error: stack protector not protecting local variables:
> > variable length buffer [-Werror=stack-protector]
> >    open_input_section (int fd)
> >    ^~~~~~~~~~~~~~~~~~
> 
> That in itself wouldn't warn. I assume you are using
> -fstack-protector[-all|strong] too.

Ah, right. Gentoo's gcc is configured with --enable-default-ssp (#define
__SSP_STRONG__ 3). That's why enabling warning alone is enough.

-- 
You are receiving this mail because:
You are on the CC list for the bug.