This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] filename in tapset nfs.proc.open and nfs.proc.release
- From: Lukas Berk <lberk at redhat dot com>
- To: David Smith <dsmith at redhat dot com>
- Cc: "Frank Ch. Eigler" <fche at redhat dot com>, hai wu <haiwu dot us at gmail dot com>, systemtap at sourceware dot org
- Date: Wed, 17 Dec 2014 12:36:32 -0500 (EST)
- Subject: Re: [PATCH] filename in tapset nfs.proc.open and nfs.proc.release
- Authentication-results: sourceware.org; auth=none
- References: <CAJ1=nZcYtxopEs-XGj-Cs89dfzA2LF8oScnc_b+JE1zysg1T=Q at mail dot gmail dot com> <548F3F8D dot 8000900 at redhat dot com> <y0m4mswhcu8 dot fsf at fche dot csb> <54919D17 dot 2020306 at redhat dot com>
Hey,
----- Original Message -----
> On 12/15/2014 02:34 PM, Frank Ch. Eigler wrote:
> > David Smith <dsmith@redhat.com> writes:
[...]
> > One way to have it both ways is to extend each these probe aliases
> > (only some dozen or so) to define a new context variable like
> > 'fullpath' sibling of 'file*name'. It would fully resolve the path
> > name. (I'd certainly switch argstr over to print that instead of the
> > last component.)
>
> I'm OK with providing a 'fullpath' variable (which would get optimized
> out if you didn't use it), but I'd need more convincing about the wisdom
> of switching argstr over to using it. As you said above "some might not
> want to pay that".
It may be the case where, those looking to use the argstr convenience variable
simply want to print out all the information being passed, regardless of
the cost, already. In that case, finding they need to craft another, very
similar script to get a piece of related information (without knowing why it
wasn't passed in the first place) could be frustrating. I've always looked
at argstr (rightly or wrongly) as 'just tell me everything being passed',
knowing I could write a more tailored script later if needed.
Either way, I'd recommend noting the choice we've made, and the alternate
variable in a manpage.
Cheers,
Lukas