[Bug runtime/17274] procfs_write.exp, the beaker killer

["fche at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17274

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
See also this fix for expect rpm:

* Thu Dec 12 2013 Vitezslav Crhonek <vcrhonek@redhat.com> - 5.45-13
- Use vsnprintf instead of vsprintf to avoid buffer overflow
  (it happens e.g. when running systemtap testsuite)

It looks like a backport is needed for RHEL6 etc.

At some point the stap testsuite must log more than
sizeof(bigbuf)=2000 bytes to trigger this expect bug.
This is probably this spot in systemtap.base/procfs_write.exp:

# This test string is ~4224 bytes long (66 lines of 64 chars).  The
# procfs kernel system will use a buffer of 4K. [...]
# We want to make sure we can handle > 4K worth of data properly.
set test_string \
"  0:12345678901234567890123456789012345678901234567890123456789
  1:12345678901234567890123456789012345678901234567890123456789
[...]
stap_run $test proc_write_test $test_string2 -DMAXSTRINGLEN=512 \
    -e $systemtap_write_script -m $test


and as per testsuite/lib/stap_run.exp:

    set cmd [concat stap -v $args]
    if [file readable $test_file_name] {
        lappend cmd $test_file_name
    }
    send_log "executing: $cmd\n"


Perhaps deliberately truncating $cmd there thusly:

    send_log "executing: [string range $cmd 0 1000]"

would do the trick.

-- 
You are receiving this mail because:
You are the assignee for the bug.