This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v10 7/7] ftrace: Introduce FTRACE_OPS_FL_SELF_FILTER for ftrace-kprobe
- From: Steven Rostedt <rostedt at goodmis dot org>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: linux-kernel at vger dot kernel dot org, Ingo Molnar <mingo at kernel dot org>, Andi Kleen <andi at firstfloor dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, x86 at kernel dot org, fche at redhat dot com, mingo at redhat dot com, systemtap at sourceware dot org, "H. Peter Anvin" <hpa at zytor dot com>, Thomas Gleixner <tglx at linutronix dot de>
- Date: Thu, 8 May 2014 23:43:55 -0400
- Subject: Re: [PATCH -tip v10 7/7] ftrace: Introduce FTRACE_OPS_FL_SELF_FILTER for ftrace-kprobe
- Authentication-results: sourceware.org; auth=none
- References: <20140508093842 dot 31767 dot 43766 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140508093930 dot 31767 dot 86419 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140508065947 dot 214f4951 at gandalf dot local dot home> <536C4761 dot 9050609 at hitachi dot com>
On Fri, 09 May 2014 12:11:29 +0900
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> > Hmm, I wonder if I should add the check for:
> >
> > !(op->flags & FTRACE_OPS_FL_STUB)
> >
> > here too? But that's another change that I'll do.
>
> Indeed. BTW, should I change ftrace_ops_control_func() too?
>
Currently there's no users of it, so I guess it could wait. Otherwise
we are adding a check that will never be true in an extreme hot path.
-- Steve