Re: systemtap test suite compilation failed: include/linux/sysfs.h:449:2: argument 2 of 'kernfs_find_and_get' differ in signedness

[Victor Kamensky <victor dot kamensky at linaro dot org>]

On 21 April 2014 13:15, William Cohen <wcohen@redhat.com> wrote:
> On 04/19/2014 02:53 PM, Naresh Kamboju wrote:
>> Hi,
>>
>> The systemtap test suite compilation failed with below error.
>
> Hi,
>
> On an ARM chromebook I have a linux kernel built from the mainline git repository (2.15.0-rc2) and the current version of systemtap checked out from the git repo. I am not seeing the error messages below.

William, Does your kernel config have CONFIG_CC_STACKPROTECTOR set?
Also what is your compiler version?

On my arndale board everything works OK with
CONFIG_CC_STACKPROTECTOR=y and Linaro OE
based rootfs with gcc Linaro GCC 4.8-2014.02:

Here are my settings:

root@genericarmv7a:~# zcat /proc/config.gz | grep STACKPROTECTOR
CONFIG_HAVE_CC_STACKPROTECTOR=y
CONFIG_CC_STACKPROTECTOR=y
# CONFIG_CC_STACKPROTECTOR_NONE is not set
CONFIG_CC_STACKPROTECTOR_REGULAR=y
# CONFIG_CC_STACKPROTECTOR_STRONG is not set

Host: Linux genericarmv7a 3.14.0 #2 SMP Mon Apr 21 14:51:04 PDT 2014
armv7l GNU/Linux
Snapshot: version 2.5/0.158, commit release-2.4-448-g80d1a1b3c06d + changes
GCC: 4.8.3 [gcc Linaro GCC 4.8-2014.02) 4.8.3 20140203 (prerelease)]
Distro: Linux
SElinux: unknown

> -Will
>
>>
>> ARCH: arm
>> ---------------
>>
>> kernel version: 3.14.0-linaro-arndale
>> systemtap location: /usr/local/bin/stap
>> systemtap version: version 2.5/0.158, commit
>> release-2.4-489-ge5fb7aeea34b + changes
>> gcc location: /usr/bin/gcc
>> gcc version: gcc (Ubuntu/Linaro 4.8.1-10ubuntu8) 4.8.1
>>
>>
>> **** failed systemtap kernel-devel smoke test:
>>
>> Makefile:622: Cannot use CONFIG_CC_STACKPROTECTOR_REGULAR:
>> -fstack-protector not supported by compiler

Most likely it is exactly what module build make says
above: either compiler too old or not configured correctly.
Try to compile something with -fstack-protector and see
whether compilation is fine.

Possible workarounds are either upgrade compiler or
configure kernel without CONFIG_CC_STACKPROTECTOR_REGULAR, i.e
CONFIG_CC_STACKPROTECTOR_NONE=y

Thanks,
Victor

>> In file included from include/linux/kobject.h:21:0,
>>                  from include/linux/module.h:16,
>>                  from /usr/local/share/systemtap/runtime/linux/runtime.h:14,
>>                  from /usr/local/share/systemtap/runtime/runtime.h:24,
>>                  from
>> /tmp/stap5eHu9T/stap_bdd64b2c1a0e84441832fdc380015719_878_src.c:24:
>> include/linux/sysfs.h: In function 'sysfs_get_dirent':
>> include/linux/sysfs.h:449:2: error: pointer targets in passing
>> argument 2 of 'kernfs_find_and_get' differ in signedness
>> [-Werror=pointer-sign]
>>   return kernfs_find_and_get(parent, name);
>>   ^
>> In file included from include/linux/sysfs.h:15:0,
>>                  from include/linux/kobject.h:21,
>>                  from include/linux/module.h:16,
>>                  from /usr/local/share/systemtap/runtime/linux/runtime.h:14,
>>                  from /usr/local/share/systemtap/runtime/runtime.h:24,
>>                  from
>> /tmp/stap5eHu9T/stap_bdd64b2c1a0e84441832fdc380015719_878_src.c:24:
>> include/linux/kernfs.h:331:1: note: expected 'const char *' but
>> argument is of type 'const unsigned char *'
>>  kernfs_find_and_get(struct kernfs_node *kn, const char *name)
>>  ^
>> cc1: all warnings being treated as errors
>> make[4]: *** [/tmp/stap5eHu9T/stap_bdd64b2c1a0e84441832fdc380015719_878_src.o]
>> Error 1
>> make[3]: *** [_module_/tmp/stap5eHu9T] Error 2
>> WARNING: kbuild exited with status: 2
>> Pass 4: compilation failed.  [man error::pass4]
>>
>> **** aborting testing.
>>
>> make[2]: Leaving directory `/root/systemtap/testsuite'
>> if test -n ""; then mail  < systemtap.sum; fi
>> make[1]: Leaving directory `/root/systemtap/testsuite'
>>
>> Please let me know if you need more information.
>>
>> Best regards
>> Naresh Kamboju
>>
>