This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v8 14/26] x86: Use NOKPROBE_SYMBOL() instead of __kprobes annotation
- From: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- To: Steven Rostedt <rostedt at goodmis dot org>
- Cc: linux-kernel at vger dot kernel dot org, Ingo Molnar <mingo at kernel dot org>, Andi Kleen <ak at linux dot intel dot com>, Andi Kleen <andi at firstfloor dot org>, Peter Zijlstra <a dot p dot zijlstra at chello dot nl>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, x86 at kernel dot org, Oleg Nesterov <oleg at redhat dot com>, fche at redhat dot com, mingo at redhat dot com, Arnaldo Carvalho de Melo <acme at ghostprotocols dot net>, "H. Peter Anvin" <hpa at zytor dot com>, Thomas Gleixner <tglx at linutronix dot de>, Seiji Aguchi <seiji dot aguchi at hds dot com>, systemtap at sourceware dot org, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>
- Date: Tue, 25 Mar 2014 19:33:39 +0900
- Subject: Re: [PATCH -tip v8 14/26] x86: Use NOKPROBE_SYMBOL() instead of __kprobes annotation
- Authentication-results: sourceware.org; auth=none
- References: <20140305115843 dot 22766 dot 8355 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140305120021 dot 22766 dot 59 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140324154518 dot 77096045 at gandalf dot local dot home>
(2014/03/25 4:45), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:21 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>> /*
>> * This is gone through when something in the kernel has done something bad
>> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
>> index ae5aafb..d00103a 100644
>> --- a/arch/x86/kernel/kprobes/core.c
>> +++ b/arch/x86/kernel/kprobes/core.c
>> @@ -112,7 +112,8 @@ struct kretprobe_blackpoint kretprobe_blacklist[] = {
>>
>> const int kretprobe_blacklist_size = ARRAY_SIZE(kretprobe_blacklist);
>>
>> -static void __kprobes __synthesize_relative_insn(void *from, void *to, u8 op)
>> +static nokprobe_inline
>> +void __synthesize_relative_insn(void *from, void *to, u8 op)
>
> I believe the proper way to break this up is:
>
> static nokprobe_inline void
> __synthesize_relative_insn(...)
Oops, there are so many incorrect style hunks...:( I'll fix those.
Thank you!
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com