This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v8 12/26] ftrace/*probes: Allow probing on some functions
- From: Steven Rostedt <rostedt at goodmis dot org>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: linux-kernel at vger dot kernel dot org, Ingo Molnar <mingo at kernel dot org>, Namhyung Kim <namhyung dot kim at lge dot com>, Andi Kleen <andi at firstfloor dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, x86 at kernel dot org, fche at redhat dot com, mingo at redhat dot com, systemtap at sourceware dot org, "H. Peter Anvin" <hpa at zytor dot com>, Thomas Gleixner <tglx at linutronix dot de>
- Date: Mon, 24 Mar 2014 15:38:30 -0400
- Subject: Re: [PATCH -tip v8 12/26] ftrace/*probes: Allow probing on some functions
- Authentication-results: sourceware.org; auth=none
- References: <20140305115843 dot 22766 dot 8355 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140305120007 dot 22766 dot 71082 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp>
On Wed, 05 Mar 2014 21:00:07 +0900
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -1209,7 +1209,7 @@ kretprobe_perf_func(struct trace_kprobe *tk, struct kretprobe_instance *ri,
> * kprobe_trace_self_tests_init() does enable_trace_probe/disable_trace_probe
> * lockless, but we can't race with this __init function.
> */
> -static __kprobes
> +static
> int kprobe_register(struct ftrace_event_call *event,
Please keep the static on the same line as int. Either the above is one
line or:
static int
kprobe_register(...)
Like the rest of the patch does.
-- Steve