This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: Re: Re: Re: Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist
- From: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- To: Ingo Molnar <mingo at kernel dot org>
- Cc: "Frank Ch. Eigler" <fche at redhat dot com>, linux-arch at vger dot kernel dot org, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, x86 at kernel dot org, lkml <linux-kernel at vger dot kernel dot org>, "Steven Rostedt (Red Hat)" <rostedt at goodmis dot org>, virtualization at lists dot linux-foundation dot org, systemtap at sourceware dot org, "David S. Miller" <davem at davemloft dot net>
- Date: Sun, 01 Dec 2013 11:16:34 +0900
- Subject: Re: Re: Re: Re: Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist
- Authentication-results: sourceware.org; auth=none
- References: <20131120042148 dot 15296 dot 88360 dot stgit at kbuild-fedora dot novalocal> <y0mvbznxi6k dot fsf at fche dot csb> <20131120153801 dot GA9743 at gmail dot com> <20131120173600 dot GK8993 at redhat dot com> <528D6C9F dot 8050809 at hitachi dot com> <20131121072938 dot GA16912 at gmail dot com> <528EC2FF dot 30301 at hitachi dot com> <528F4406 dot 3090309 at hitachi dot com> <20131127133045 dot GC18422 at gmail dot com> <52971E66 dot 9080006 at hitachi dot com> <20131130134618 dot GA18768 at gmail dot com>
(2013/11/30 22:46), Ingo Molnar wrote:
>>>> Anyway, to fix all of them, I think we need file-based blacklist
>>>> especially for assembler symbols.
>>>
>>> assembler symbols shouldn't be particular hard either, just put them
>>> into the noprobes section.
>>
>> Would you mean .kprobes.text? Hmm, I hope not to use it anymore, but
>> yeah, bugfix is more important. Agreed.
>
> No, why not put the symbol address into the 'blacklist' section,
> within the asm file? We fill out exception table entries in .S files
> as well, see the _ASM_EXTABLE() macro, it's possible to do all that.
Oh! I got it. Thank you for the pointer! :)
>
> It needs not a CPP macro but an assembly macro.
OK, I'll try that.
Thanks again,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com