[Bug runtime/15805] maps should not be allocated with k*alloc

["dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=15805

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7135|0                           |1
        is obsolete|                            |

--- Comment #5 from David Smith <dsmith at redhat dot com> ---
Created attachment 7143
  --> http://sourceware.org/bugzilla/attachment.cgi?id=7143&action=edit
v2 patch

Here's a new version of the patch that takes allocations from over 67000 to 67.
With this new patch, here are some timed runs:

====
# time stap -DUSE_KMALLOC --disable-cache
../src/testsuite/systemtap.maps/ix_clear.stp 
foo[1] = 1 1
ERROR: empty aggregate near operator '@min' at
../src/testsuite/systemtap.maps/ix_clear.stp:14:45
WARNING: Number of errors: 1, skipped probes: 0
WARNING: /usr/local/bin/staprun exited with status: 1
Pass 5: run failed.  [man error::pass5]

real    0m20.810s
user    0m17.327s
sys    0m2.425s
# time stap --disable-cache ../src/testsuite/systemtap.maps/ix_clear.stp 
foo[1] = 1 1
ERROR: empty aggregate near operator '@min' at
../src/testsuite/systemtap.maps/ix_clear.stp:14:45
WARNING: Number of errors: 1, skipped probes: 0
WARNING: /usr/local/bin/staprun exited with status: 1
Pass 5: run failed.  [man error::pass5]

real    0m20.704s
user    0m17.352s
sys    0m2.306s
====

With this version of the patch, the new kmalloc and vmalloc versions of the
code times are very similar. With this patch, all of the systemtap.maps/*.exp
tests pass. I haven't done a full testsuite run.

Note that allocations could be lowered further by using ideas from the dyninst
runtime, which only makes 1 allocation per map.

-- 
You are receiving this mail because:
You are the assignee for the bug.