This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug kprobes/15675] 'kprobe.module("foo").function("bar")' probes do not work
- From: "dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sourceware dot org
- Date: Tue, 25 Jun 2013 18:50:59 +0000
- Subject: [Bug kprobes/15675] 'kprobe.module("foo").function("bar")' probes do not work
- Auto-submitted: auto-generated
- References: <bug-15675-6586 at http dot sourceware dot org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=15675
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from David Smith <dsmith at redhat dot com> ---
This problem is now fixed. I took your suggested code changes and made the
systemtap translator emit code like that in the following commit:
=====
commit 8c2728197442816189a94f3f241186bcf6cb245a
Author: Yang Wen <yangwen@huawei.com>
Date: Tue Jun 25 13:40:29 2013 -0500
Fix PR15675 by making 'probe kprobe.module("foo").function("bar") work.
* tapsets.cxx (kprobe_derived_probe_group::emit_module_decls): Fix emitted
kprobe_resolve() to lookup "module:function" symbols correctly.
====
I then wondered why we hadn't seen this before. It was because we never tested
it. So, after fixing bug #10395 to fix the kmodule.exp testcase, I added a new
test to that testcase to test probing 'kprobe.module("foo").function("bar")':
====
commit 5039ed9600735c3b2fc23068f5c15282639ad042
Author: David Smith <dsmith@redhat.com>
Date: Tue Jun 25 13:43:58 2013 -0500
Add a new test for probing 'kprobe.module("foo").function("bar") (PR15675).
* testsuite/systemtap.base/kprobe_module.stp: Add new test for
'kprobe.module("foo").function("bar")'.
* testsuite/systemtap.base/kmodule.exp: Run new kprobe_module.stp test.
====
Thanks for the code fix.
--
You are receiving this mail because:
You are the assignee for the bug.