This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug releng/14655] kallsyms_lookup_name is not exported by kernel versions prior to 2.6.33


http://sourceware.org/bugzilla/show_bug.cgi?id=14655

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

--- Comment #2 from David Smith <dsmith at redhat dot com> 2012-10-03 21:22:00 UTC ---
I've taken a look at your patch.  I know this is a first draft, but it misses
use of kallsyms_lookup_name() in runtime/stp_task_work.c and
runtime/transport/transport.c.

In general, kernel version checks don't work well.  Systemtap tries to work
with so many kernels, which may or may not have a feature enabled, backported,
etc. to it.

Here's a possible different approach. Instead of a kernel version check, do an
output_exportconf() test to see if kallsyms_lookup_name is exported (in
buildrun.cxx).  If not, define STAPCONF_KALLSYMS_LOOKUP_NAME_UNEXPORTED (or
some better name).  If that is defined, define a dummy kallsyms_lookup_name()
function in the runtime that either warns or errors and always returns NULL.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]