Re: tcpmib.InSeg probe point needs some default functions

[William Cohen <wcohen at redhat dot com>]

On 07/12/2010 09:50 AM, David Smith wrote:
> On 07/09/2010 04:10 PM, William Cohen wrote:
>> I was looking through the test results for the systemtap.examples and found that following command used to determine whether the test should run doesn't work for systemtap.examples/network/tcpipstat.stp:
>>
>>    stap -l 'tcpmib.InSegs'
>>
>> Looking through the tapset found that it expect a couple functions to be available. The attached patch adds those functions in a separate file so the user can overide the functions. If there are no objects about the patch I will check it in.
>>
>>     Include default tcpmib_filter_key and ipmib_filter_key functions in tapset
>>
>>     The tcpmib.InSegs probe point in the tcpmib.stp tapset makes uses
>>     of the tcpmib_filter_key() and the ipmib_filter_key() functions.
>>     Without these default functions the "stap -l 'tcpmib.InSegs'"
>>     command does not work.
> 
> Hmm, looking at your patch I wonder if it makes more sense to separate
> those functions, 1 per file.  Could there be a time when you'd want the
> 1 default function but want to override the other function?
> 

Hi David,

I was just thinking that after reading Josh's email. The pr11457 also refers to a function that is not included in the patch suggested patch,  linuxmib_filter_key().

-Will