This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old

From: Arnaldo Carvalho de Melo <acme at infradead dot org>
To: Masami Hiramatsu <mhiramat at redhat dot com>
Cc: Robert Richter <robert dot richter at amd dot com>, Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, Roland McGrath <roland at redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>
Date: Mon, 10 May 2010 16:15:01 -0300
Subject: Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old
References: <20100510171207.26029.97604.stgit@localhost6.localdomain6> <20100510172854.GD30926@ghostprotocols.net> <20100510183654.GH6450@erda.amd.com> <4BE8571E.4020403@redhat.com>

Em Mon, May 10, 2010 at 02:57:34PM -0400, Masami Hiramatsu escreveu:
> Hmm, ok, version.h is also introduced at the same time.
> 
> # git log ./config/version.h.in
> commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60
> Author: Roland McGrath <roland@redhat.com>
> Date:   Tue Dec 16 17:03:03 2008 -0800
> 
>     Install elfutils/version.h header for library compatibility checking.
> 
> So, I think we'd better set NO_DWARF if the elfutils
> is older than 0.138, since we can't check API compatibility
> easily.

Well, for that you can just add some of the code you ifdefed in this
patch into the tools/perf/Makefile test, or better, duplicate the test,
including just the CPI stuff in the new test, and then set NO_DWARF_CFI
and use it as the ifdef condition :-)

- Arnaldo

Follow-Ups:
- Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old
  - From: Masami Hiramatsu

References:
- [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old
  - From: Masami Hiramatsu
- Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old
  - From: Arnaldo Carvalho de Melo
- Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old
  - From: Robert Richter
- Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old
  - From: Masami Hiramatsu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]