This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v3] [RFC] tracepoint: Add signal coredump tracepoint
- From: KOSAKI Motohiro <kosaki dot motohiro at jp dot fujitsu dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: kosaki dot motohiro at jp dot fujitsu dot com, Ingo Molnar <mingo at elte dot hu>, Andrew Morton<akpm at linux-foundation dot org>, lkml<linux-kernel at vger dot kernel dot org>, systemtap<systemtap at sources dot redhat dot com>, DLE<dle-develop at lists dot sourceforge dot net>, Oleg Nesterov <oleg at redhat dot com>, Roland McGrath <roland at redhat dot com>, Jason Baron <jbaron at redhat dot com>
- Date: Wed, 9 Dec 2009 14:34:46 +0900 (JST)
- Subject: Re: [PATCH v3] [RFC] tracepoint: Add signal coredump tracepoint
- References: <20091208104324.B589.A69D9226@jp.fujitsu.com> <20091208204007.31287.62096.stgit@dhcp-100-2-132.bos.redhat.com>
> + TP_fast_assign(
> + __entry->sig = (int)cprm->signr;
> + __entry->limit = cprm->limit;
> + __entry->flags = cprm->mm_flags;
> + __entry->retval = retval;
> + __assign_str(name, core_name);
> + ),
> +
> + TP_printk("sig=%d limit=%lu dumpable=0x%lx dump_filter=0x%lx "
> + "corename=\"%s\" retval=%d",
> + __entry->sig, __entry->limit,
> + __entry->flags & MMF_DUMPABLE_MASK,
> + (__entry->flags & MMF_DUMP_FILTER_MASK) >>
> + MMF_DUMP_FILTER_SHIFT,
> + __get_str(name), __entry->retval)
> +);
> #endif /* _TRACE_SIGNAL_H */
I don't think "limit" is userfriendly name, core_limit or core_size_limit is better?
plus, we have core_pipe_limit sysctl too. (it's similar but different concept limit).
other parts looks good to me.