Re: [PATCH V5] Tracepoint Tapset for Memory Subsystem

[Wenji Huang <wenji dot huang at oracle dot com>]

Hi,

Rajasekhar Duddu wrote:
> +/* The Formal Parameters will be displayed if available, otherwise \
> +		 "0" or "unknown" will be displayed */
> +
> +probe __vm.kmalloc.tp = kernel.trace("kmalloc") {
> +	name = "kmalloc"
> +	call_site = $call_site
> +	caller_function = symname(call_site)
> +	bytes_req = $bytes_req
> +	bytes_alloc = $bytes_alloc
> +	gfp_flags = $gfp_flags
> +	gfp_flag_name = __gfp_flag_str($gfp_flags)
> +	ptr = $ptr
> +}
> +
> +/* It is unsafe to invoke __builtin_return_address() \
> +presently(to get call_site for kporbe based probes) \
> +and that it can be improved later when fix for bugs bz#6961 and bz#6580 is available. */
> +
> +probe __vm.kmalloc.kp = kernel.function("kmalloc").return {
> +	name = "kmalloc"
> +	call_site = 0
> +	caller_function = "unknown"
> +	bytes_req = $size
> +	bytes_alloc = "unknown"
why let bytes_alloc be "unknown", not 0 ?
The type is not consistent with the above one.

Same issue exists in the following part.


Regards,
Wenji