This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Tracepoint Tapset for Memory Subsystem

On Fri, Sep 25, 2009 at 02:50:35PM -0700, Josh Stone wrote:

> > Changelog:
> >     Removed the Hardcoded constants in converting GFPFLAGS.
> >     Added a kprobe based fallback probe to kfree.
> 
> Why is kfree the only one you're adding with a kprobe fallback?
> This is
> a good feature to have!
> 

Hi Josh,
	many thanks for your comments, I have tried to have fallback
probes for all the tracepoints, but I found that the variables
exported by the other tracepoints(except kfree) are getting changed,
so I could not have fallback for all of them.

I will modify my patch according to your other comments.

Thanks
-- 
Rajasekhar Duddu (rajduddu@linux.vnet.ibm.com),
Linux on System z - CSVT, IBM LTC, Bangalore.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]