Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.9.9-340-g6ecd877

[Mark Wielaard <mjw at redhat dot com>]

Hi Frank,

On Thu, 2009-09-17 at 02:39 +0000, fche@sourceware.org wrote:
> commit 6ecd877049008c5abe9c6720ea8fc64732f47eb5
> Author: Frank Ch. Eigler <fche@elastic.org>
> Date:   Wed Sep 16 22:32:28 2009 -0400
> 
>     PR10650: markup some unprivileged-safe tapset functions
>     
>     Add /* unprivileged */ to a variety of tapset embedded-c functions,
>     together with uid-assertion-checking code as needed.  This is only
>     an initial set, and may need to grow or shrink after further testing.
>     
>     Prototyped-By: Dave Brolley <brolley@redhat.com>
>     
>     * runtime/runtime.h (is_myproc, assert_is_myproc): New macros.
>     * runtime/addr-map.c (lookup_bad_addr): Reject if !is_myproc
>       in unprivileged mode.
>     * runtime/print.c (_stp_print_kernel_info): Add unprivileged
>       mode info.
>     * tapset/DEVGUIDE: Document /* pure */ and /* unprivileged */.
>     * tapset/*.stp: Add /* unprivileged */ here and there, in
>       questionable cases along with an assert_is_myproc().

According to git bisect this commit caused exelib.exp to show lots of
failures. 

# of expected passes            105
# of unexpected failures         80

I haven't figures out why yet. But if you have time, could you take a
look? Note that to speed up the test exelib.exp only runs the giant all
in one libmarkunamestack test. But in exelib.exp you can also enable the
individual tests (lib mark uname ustack) to better see what precisely
fails.

Thanks,

Mark