This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH tracing/kprobes 4/7] tracing/kprobes: Add event profiling support
- From: Frederic Weisbecker <fweisbec at gmail dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Steven Rostedt <rostedt at goodmis dot org>, Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Andi Kleen <ak at linux dot intel dot com>, Christoph Hellwig <hch at infradead dot org>, "Frank Ch. Eigler" <fche at redhat dot com>, "H. Peter Anvin" <hpa at zytor dot com>, Jason Baron <jbaron at redhat dot com>, "K.Prasad" <prasad at linux dot vnet dot ibm dot com>, Lai Jiangshan <laijs at cn dot fujitsu dot com>, Li Zefan <lizf at cn dot fujitsu dot com>, Peter Zijlstra <peterz at infradead dot org>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, Tom Zanussi <tzanussi at gmail dot com>
- Date: Fri, 11 Sep 2009 05:12:54 +0200
- Subject: Re: [PATCH tracing/kprobes 4/7] tracing/kprobes: Add event profiling support
- References: <20090910235258.22412.29317.stgit@dhcp-100-2-132.bos.redhat.com> <20090910235329.22412.94731.stgit@dhcp-100-2-132.bos.redhat.com>
On Thu, Sep 10, 2009 at 07:53:30PM -0400, Masami Hiramatsu wrote:
> +#ifdef CONFIG_EVENT_PROFILE
> +
> +/* Kprobe profile handler */
> +static __kprobes int kprobe_profile_func(struct kprobe *kp,
> + struct pt_regs *regs)
> +{
> + struct trace_probe *tp = container_of(kp, struct trace_probe, rp.kp);
> + struct ftrace_event_call *call = &tp->call;
> + struct kprobe_trace_entry *entry;
> + int size, i, pc;
> + unsigned long irq_flags;
> +
> + local_save_flags(irq_flags);
> + pc = preempt_count();
> +
> + size = SIZEOF_KPROBE_TRACE_ENTRY(tp->nr_args);
Note that the end-result must be u64 aligned for perf ring buffer.
And this is a bit tricky.
What is inserted in the perf ring buffer is:
raw_trace + (u32)raw_trace_size
So we must ensure that sizeof(raw_trace) + sizeof(u32)
is well u64 aligned.
We don't insert the trace_size ourself though, this is done
from kernel/perf_counter.c
But we need to handle the size of the size (sorry) in the final
alignment.
To sum-up: sizeof(raw_trace) doesn't need (shouldn't) to be u64
aligned but sizeof(raw_trace) + sizeof(u32) must be.
Given this aligned size, we then substract it by sizeof(u32)
to have the needed size of the raw entry.
This result gives you the size of char raw_data[], which
is also the same size passed in perf_tpcounter_event().
See?
That's why we have this in trace/ftrace.h:
__data_size = "the real entry data size"
__entry_size = ALIGN(__data_size + sizeof(*entry) + sizeof(u32), sizeof(u64));
__entry_size -= sizeof(u32);
do {
char raw_data[__entry_size];
...
perf_tpcounter_event(event_call->id, __addr, __count, entry,
__entry_size);
...
} while (0);
> +static int probe_profile_enable(struct ftrace_event_call *call)
> +{
> + struct trace_probe *tp = (struct trace_probe *)call->data;
> +
> + if (atomic_inc_return(&call->profile_count))
> + return 0;
> +
> + if (probe_is_return(tp)) {
> + tp->rp.handler = kretprobe_profile_func;
> + return enable_kretprobe(&tp->rp);
> + } else {
> + tp->rp.kp.pre_handler = kprobe_profile_func;
> + return enable_kprobe(&tp->rp.kp);
> + }
> +}
May be I misunderstood but it seems that concurrent uses of
ftrace and perf would really mess up the result, as one would
overwrite the handler of the other.
Even though it's hard to imagine one using both at the same
time on the same probe, but still...
Is it possible to have two kprobes having the exact same
properties? (pointing to the same address, having the same
probe handlers, etc...)
Another solution would be to allow kprobes to have multiple
handlers.