This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC][PATCH -tip 4/9] power: add kernel_trap_sp()
- From: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>
- To: Benjamin Herrenschmidt <benh at kernel dot crashing dot org>
- Cc: Masami Hiramatsu <mhiramat at redhat dot com>, Ingo Molnar <mingo at elte dot hu>, linuxppc-dev at ozlabs dot org, systemtap-ml <systemtap at sources dot redhat dot com>, Steven Rostedt <rostedt at goodmis dot org>, LKML <linux-kernel at vger dot kernel dot org>
- Date: Fri, 20 Mar 2009 13:03:34 +0530
- Subject: Re: [RFC][PATCH -tip 4/9] power: add kernel_trap_sp()
- References: <49C2B4BF.4080904@redhat.com> <1237527760.25062.567.camel@pasglop>
- Reply-to: ananth at in dot ibm dot com
On Fri, Mar 20, 2009 at 04:42:40PM +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2009-03-19 at 17:10 -0400, Masami Hiramatsu wrote:
> > Add kernel_trap_sp() on powerpc, based on systemtap's runtime/regs.h.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> I haven't looked at the usage of it, but it's weird to have something
> call "kernel_trap_sp" that returns the -user- stack pointer... is
> this really what's expected here ?
In the current usage scenario, this gets called only with a pt_regs
snapshot from in kernel. user_stack_pointer() is a misnomer though;
all this macro needs is to return the stack pointer from the given
pt_regs.
Ananth