This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch]Add a function kernel_string2 for copy non-0-terminated string with fixed length from kernel space at given address.


Cai Fei wrote:
> So I added a function kernel_string2 for copy non-0-terminated string
> with fixed length from kernel space at given address. Also, the man
> paged is updated.

The new function looks fine.  My only suggestion is that a more
meaningful name would be nice.  Maybe kernel_string_n or
kernel_string_max.

Oh, tests would also be nice.

Thanks,

Josh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]