Re: [patch 3/3] Trace sample

[David Wilder <dwilder at us dot ibm dot com>]

Randy Dunlap wrote:
> On Tue, 02 Oct 2007 09:33:25 -0700 David J. Wilder wrote:
>
> > Trace example - Adds the trace example to samples/
> >
> > Signed-off-by: David Wilder <dwilder@us.ibm.com>
> > ---
> >  samples/Kconfig            |    6 ++
> >  samples/Makefile           |    1 +
> >  samples/trace/Makefile     |    4 +
> >  samples/trace/fork_trace.c |  132 ++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 143 insertions(+), 0 deletions(-)
> >
> > diff --git a/samples/Kconfig b/samples/Kconfig
> > index 57bb223..e11c806 100644
> > --- a/samples/Kconfig
> > +++ b/samples/Kconfig
> > @@ -13,4 +13,10 @@ config SAMPLE_MARKERS
> >  	help
> >  	  This build markers example modules.
> >  
> > +config SAMPLE_TRACE
> > +	tristate "Build trace example -- loadable modules only"
> > +	depends on TRACE && m
>
> The sample code uses kprobes, so this should also be:
>
> 	depends on KPROBES
>
> Is (are?) kprobes always needed for trace?


No, just the sample.

 If so, the documentation
> probably should mention that also (along with relay & debugfs).
...