This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Kprobes i386 fix for mark ro data
- From: "Ian McDonald" <ian dot mcdonald at jandi dot co dot nz>
- To: prasanna at in dot ibm dot com
- Cc: "Andrew Morton" <akpm at linux-foundation dot org>, "Andi Kleen" <ak at suse dot de>, "Jim Keniston" <jkenisto at us dot ibm dot com>, "Chuck Ebbert" <cebbert at redhat dot com>, "Linux Kernel Mailing List" <linux-kernel at vger dot kernel dot org>, ananth at in dot ibm dot com, anil dot s dot keshavamurthy at intel dot com, "David S. Miller" <davem at davemloft dot net>, "Patrick Andrieux" <patrick dot andrieux at gmail dot com>, "DCCP Mailing List" <dccp at vger dot kernel dot org>, jbeulich at novell dot com, systemtap at sources dot redhat dot com
- Date: Sun, 10 Jun 2007 18:24:15 +1200
- Subject: Re: [PATCH] Kprobes i386 fix for mark ro data
- References: <5640c7e00706061347v42c9ecbahb5354f6687a70a78@mail.gmail.com> <46673B76.2090508@redhat.com> <5640c7e00706061612h62074699wdbd2725654a164@mail.gmail.com> <20070607042229.GA9350@in.ibm.com>
On 6/7/07, S. P. Prasanna <prasanna@in.ibm.com> wrote:
> >It faulted when it tried to write the breakpoint instruction into the
> >running kernel's executable code. Apparently the kernel code is now marked
> >read-only?
> >
> >
> Yes it would appear to be the case as user has CONFIG_DEBUG_RODATA
> set. Patrick - can you turn this off and retest? It's under Kernel
> Hacking, Write protect kernel read only data structures.
>
Ian,
Please find the fix as suggested by Andi Kleen
for the above stated problem.
Thanks
Prasanna
I went to test the fix and first of all went to replicate the problem.
My build has CONFIG_DEBUG_RODATA set but the problem does not occur
without the patch. Should I be concerned about this and raise a bug
for that as I would think that means there is a problem that the read
only protection isn't working (this is off Linus' tree synced
tonight).
Patrick - can you test whether this patch fixes your problem? You said
disabling CONFIG_DEBUG_RODATA fixed your problem but can you try
re-enabling and testing this patch?
Ian
--
Web: http://wand.net.nz/~iam4/
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group