Re: ARM port of testsuite and general testsuite fixes

[David Smith <dsmith at redhat dot com>]

Quentin Barnes wrote:
> > Well, you've improved things, but you're still missing the "Pass 4" 
> > output line.
>
> That's because of another bug in the expect script.  (I've fixed a
> dozen of these bugs now so I'm rather disappointed with myself that
> I missed this one until now.)

Great!  I'm glad you fixed it.

> As an aside, any reason that spaces are escaped in these regular
> expressions?  I didn't change it in this patch, but why are the
> regular expressions written like this:
>  -re {^Pass\ [1234]:[^\r]*\ in\ [^\r]*\ ms\.\r\n} {exp_continue}
>  -re {^Pass\ [34]: using cached [^\r\n]+\r\n} {incr cached 1; exp_continue}
>
> And not like this?:
>  -re {^Pass [1234]:[^\r]* in [^\r]* ms\.\r\n} {exp_continue}
>  -re {^Pass [34]: using cached [^\r\n]+\r\n}  {incr cached 1; exp_continue}

Good question.  I believe it is to work around an expect bug - someone 
else might remember the details.

--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)