This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug translator/2422] module("*") probes fail with debug-info-less modules
- From: "guanglei at cn dot ibm dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: 31 Jul 2006 14:32:49 -0000
- Subject: [Bug translator/2422] module("*") probes fail with debug-info-less modules
- References: <20060306154835.2422.wcohen@redhat.com>
- Reply-to: sourceware-bugzilla at sourceware dot org
------- Additional Comments From guanglei at cn dot ibm dot com 2006-07-31 14:32 -------
(In reply to comment #3)
> What happens if we just switch to get_module_dwarf(false) altogether? (Testing
> for equality with "*" would be insufficient - we have wildcards like "*foo*".)
Simply calling get_module_dwarf(false) seems enough. Here is a patch:
RCS file: /cvs/systemtap/src/tapsets.cxx,v
retrieving revision 1.137
diff -r1.137 tapsets.cxx
558c558
< void get_module_dwarf(bool required = true)
---
> void get_module_dwarf(bool required = false)
585c585
< get_module_dwarf(true);
---
> get_module_dwarf(false);
This patch will:
if MPATTERN contains wildcard(*,?,[])
{
foreach module in MPATTERN
{
if this module has no debuginfo
give a warning and continue
}
if all modules have no debuginfo
&& this probe point is not optional
{
give an error and stop
} else
give a warning and continue
} else {
if this module has no debuginfo
&& this probe point is not optional
give an error and stop
else
give a warning and continue
}
I tried different combinations and it passed tests:
probe module("*ath*").function("*dispatch*"), kernel.function("sys_getsid")
probe module("*ath*").function("*dispatch*") ?, kernel.function("sys_getsid")
probe module("ath_[abcp]ci").function("*dispatch*"), kernel.function("sys_getsid")
probe module("ath_[abcp]ci").function("*dispatch*")?, kernel.function("sys_getsid")
probe module("ath_[abcp]ci").statement("0xf89aae29")
probe module("ath_[abcp]ci").statement("0xf89aae29")?
...
--
http://sourceware.org/bugzilla/show_bug.cgi?id=2422
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.