This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] [2/5] Switch Kprobes inline functions to __kprobes for x86_64
- From: Andi Kleen <ak at suse dot de>
- To: prasanna at in dot ibm dot com
- Cc: akpm at osdl dot org, davem at davemloft dot net, linux-kernel at vger dot kernel dot org, ananth at in dot ibm dot com, anil dot s dot keshavamurthy at intel dot com, systemtap at sources dot redhat dot com
- Date: Tue, 11 Apr 2006 04:41:59 +0200
- Subject: Re: [PATCH] [2/5] Switch Kprobes inline functions to __kprobes for x86_64
- References: <20060410055712.GA24711@in.ibm.com> <20060410055813.GA23879@in.ibm.com>
On Monday 10 April 2006 07:58, Prasanna S Panchamukhi wrote:
> Andrew Morton pointed out that compiler might not inline the functions
> marked for inline in kprobes. There by allowing the insertion of probes
> on these kprobes routines, which might cause recursion. This patch
> removes all such inline and adds them to kprobes section there by
> disallowing probes on all such routines. Some of the routines can
> even still be inlined, since these routines gets executed after
> the kprobes had done necessay setup for reentrancy.
Ok for me.
-Andi